Skip to content

Clean Code for apitools/org.eclipse.pde.api.tools.ui#2316

Open
eclipse-pde-bot wants to merge 2 commits into
masterfrom
clean-code/apitools/org.eclipse.pde.api.tools.ui
Open

Clean Code for apitools/org.eclipse.pde.api.tools.ui#2316
eclipse-pde-bot wants to merge 2 commits into
masterfrom
clean-code/apitools/org.eclipse.pde.api.tools.ui

Conversation

@eclipse-pde-bot

Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

Test Results

 66 files   -    60   66 suites   - 60   37s ⏱️ - 34m 2s
133 tests  - 3 377  133 ✅  - 3 323  0 💤  -  54  0 ❌ ±0 
510 runs   - 8 823  510 ✅  - 8 693  0 💤  - 130  0 ❌ ±0 

Results for commit a6591b3. ± Comparison against base commit af2b487.

This pull request removes 3377 tests.
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test1
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test2
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test3
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test4
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test5
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test6
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test7
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingApiFreezeAntTaskTests ‑ test1
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingApiFreezeAntTaskTests ‑ test2
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingApiFreezeAntTaskTests ‑ test3
…

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/apitools/org.eclipse.pde.api.tools.ui branch from 5a118bc to 5fd4f53 Compare June 3, 2026 04:52
@eclipse-pde-bot

eclipse-pde-bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

apitools/org.eclipse.pde.api.tools.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 0ca5eadbd57f6b0e9265c5167fb337a6b5f7b9d7 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Fri, 5 Jun 2026 03:18:10 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/apitools/org.eclipse.pde.api.tools.ui/META-INF/MANIFEST.MF b/apitools/org.eclipse.pde.api.tools.ui/META-INF/MANIFEST.MF
index 9a4170a7ac..f54d833de4 100644
--- a/apitools/org.eclipse.pde.api.tools.ui/META-INF/MANIFEST.MF
+++ b/apitools/org.eclipse.pde.api.tools.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.api.tools.ui; singleton:=true
-Bundle-Version: 1.4.300.qualifier
+Bundle-Version: 1.4.400.qualifier
 Bundle-Localization: plugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/apitools/org.eclipse.pde.api.tools.ui branch from c13fa45 to 7c54b6c Compare June 4, 2026 03:11
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/apitools/org.eclipse.pde.api.tools.ui branch from 1538cf9 to 72fbfef Compare June 5, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant