Skip to content

Make spyPart shortcut attribute optional #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vogella wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make spyPart shortcut attribute optional #2326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/org.eclipse.pde.spy.core/forceQualifierUpdate.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# To force a version qualifier update add the bug here
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/1184
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/1659
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/1659
https://github.com/eclipse-pde/eclipse.pde/pull/2326
4 changes: 3 additions & 1 deletion ui/org.eclipse.pde.spy.core/src/org/eclipse/pde/spy/core/SpyProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ public void process(IExtensionRegistry extRegistry) {
// Bind the command with the binding, and add the view ID as
// parameter.
// The part class name will be the ID of the part descriptor
bindSpyKeyBinding(bindingTable, shortCut, command, partID);
if (shortCut != null && !shortCut.isBlank()) {
bindSpyKeyBinding(bindingTable, shortCut, command, partID);
}

// Add the descriptor in application
addSpyPartDescriptor(partID, partName, iconPath, partClass, desc);
Expand Down
Loading