Skip to content

Unify recording of Bundle changes in BundleManifestChange#2334

Open
HannesWell wants to merge 1 commit into
eclipse-pde:masterfrom
HannesWell:bundle-change-recording-unified
Open

Unify recording of Bundle changes in BundleManifestChange#2334
HannesWell wants to merge 1 commit into
eclipse-pde:masterfrom
HannesWell:bundle-change-recording-unified

Conversation

@HannesWell
Copy link
Copy Markdown
Member

@nburnwal09 since you recently worked in this area, what do you think?

@github-actions
Copy link
Copy Markdown

Test Results

  126 files  +  9    126 suites  +9   36m 50s ⏱️ + 4m 25s
3 502 tests ±  0  3 448 ✅ ±  0   54 💤 ±0  0 ❌ ±0 
9 321 runs  +166  9 191 ✅ +160  130 💤 +6  0 ❌ ±0 

Results for commit 1e7ab6d. ± Comparison against base commit 4074bd4.

@nburnwal09
Copy link
Copy Markdown
Contributor

@HannesWell
The changes looks great. The refactoring is eliminating many line of duplicated code and is more clean and simplified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants