Fix "Message not found for id: 0" in API tools compatible delta messages#2336
Merged
Conversation
Add missing message mappings in Messages.getKey() for: - INTERFACE + ADDED + DEFAULT_METHOD (new key 113) - INTERFACE + ADDED + SUPER_INTERFACE_DEFAULT_METHOD (new key 115) - INTERFACE + CHANGED + INCREASE_ACCESS (new key 114) - ENUM + ADDED + TYPE_MEMBER (reuse key 16) - ANNOTATION + ADDED + TYPE_MEMBER (reuse key 16) Also fix ClassFileComparator to use SUPER_INTERFACE_DEFAULT_METHOD (not DEFAULT_METHOD) when reporting methods contributed by newly added superinterfaces in the expanded set path (line 501). Add reproducing tests: InterfaceDeltaTests.test42/43, EnumDeltaTests.test17, AnnotationDeltaTests.test12. Fixes eclipse-pde#2332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing message mappings in Messages.getKey() for:
Also fix ClassFileComparator to use SUPER_INTERFACE_DEFAULT_METHOD
(not DEFAULT_METHOD) when reporting methods contributed by newly
added superinterfaces in the expanded set path (line 501).
Add reproducing tests: InterfaceDeltaTests.test42/43,
EnumDeltaTests.test17, AnnotationDeltaTests.test12.
Fixes #2332