Skip to content

Remove unnecessary single quotes for links#2342

Open
deepika-u wants to merge 1 commit into
eclipse-pde:masterfrom
deepika-u:quotes_4_hyperlink
Open

Remove unnecessary single quotes for links#2342
deepika-u wants to merge 1 commit into
eclipse-pde:masterfrom
deepika-u:quotes_4_hyperlink

Conversation

@deepika-u
Copy link
Copy Markdown
Contributor

This change removes the unnecessary quotes around Text Editors and Colors and Fonts in the properties strings.

The single quotes around the placeholder text in the preference page were likely added following older UI conventions. Quotes often differentiate literal text or placeholders from the rest of the message. Since the text already appears as a blue clickable link, the additional quotes are unnecessary. Removing them keeps the link still clickable while making the message cleaner and consistent with other preference links across the UI, where such quotes are not used.
The PR changes the link like other links provided in other areas in Preference page like File Associations.
As an example ->
image

Before pr ->
image

After pr ->
image

@github-actions
Copy link
Copy Markdown

Test Results

  126 files  ±0    126 suites  ±0   32m 54s ⏱️ - 2m 55s
3 510 tests ±0  3 456 ✅ ±0   54 💤 ±0  0 ❌ ±0 
9 333 runs  ±0  9 203 ✅ ±0  130 💤 ±0  0 ❌ ±0 

Results for commit a73cd68. ± Comparison against base commit 0c81951.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant