Track UserScope in preference spy#2347
Open
vogella wants to merge 1 commit into
Open
Conversation
UserScope was added to Equinox preferences in eclipse-equinox/equinox#446 and stores per-user-global preferences under <user.home>/.eclipse. The spy already watches BundleDefaults, Configuration, Default and Instance, so user-scoped changes were silently missed. Register the same change listener on UserScope and include it in the Show All Preferences walker. Fixes eclipse-pde#2344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planned for 4.41
UserScopewas added to Equinox preferences in eclipse-equinox/equinox#446 and stores per-user-global preferences under<user.home>/.eclipse. The Preference Spy already watchesBundleDefaults,Configuration,DefaultandInstance, so user-scoped changes were silently missed. This PR registers the same change listener onUserScopeand includes it in the Show All Preferences walker, so anything written there now shows up in the spy.Independent of #2345 and #2346; touches only
PreferenceSpyAddonandShowAllPreferencesHandler.Fixes #2344.