[win32] Add workaround for missing selection indicator for menu item with image on Win11 (#501)

[wahlbrink]

For menu items of type CHECK and RADIO with an image, it create an second image with a checkmark/circle over the original image.

[wahlbrink]

[merks]

@wahlbrink

This problem is the only reason why I have not upgraded by system to Windows 11.

Can you show a screen capture of how it looks with and without your changes? I'm not sure I can really test/see that on Windows 10.

@HeikoKlare

This problem has festered for years and I don't think Windows 11 itself will ever make the problem go away. It would be great for this to be reviewed to make any necessary changes or improvements.

[merks]

Oh, I think this is the change:

[Phillipus]

What should happen is that the menu item image is highlighted by a surrounding square (blue in light theme). Wasn't this possible as POC in #501?

[github-actions]

Test Results

   545 files  ±0     545 suites  ±0   33m 1s ⏱️ - 6m 52s
 4 377 tests ±0   4 359 ✅ ±0   18 💤 ±0  0 ❌ ±0 
16 647 runs  ±0  16 506 ✅ ±0  141 💤 ±0  0 ❌ ±0 

Results for commit 1a6d4d4. ± Comparison against base commit f498ca3.

[merks]

What should happen is that the menu item image is highlighted by a surrounding square (blue in light theme). Wasn't this possible as POC in #501?

The should happen is based on how it looked before, which was quite (very) nice. In fact kind of nicer visually than this proposal and more familiar. But, at this point 6 months later, I'm willing to say what should happen is something, maybe even anything reasonable, because that is better than nothing at all which we have currently and have had for far too long.

I really hope to see movement here...

[Phillipus]

@merks Agreed. I just thought that the highlighted square was kind of working as POC in #501 ?

[merks]

@merks Agreed. I just thought that the highlighted square was kind of working as POC in #501 ?

Yes, I think that approach is prettier. 😍 I just don't know if it's harder to implement and maybe harder to match the native styling. I don't know much, except that I'm willing to compromise at this point...

[HeikoKlare]

Thank you for this proposal!
I agree that any solution to the issue is better than none. And given that this proposes a way to custom-draw the icon to be shown, it might be easy to just exchange how the icon is drawn later on if desired (replacing the check with a highlighted square in the background or whatever we agree on).
In the long run, we should probably try to mimic the highlighted square. Even though the check mark is what the more modern UI frameworks in Windows use, the highlighted square fits to every other visualization of selection we have in Eclipse right now.

At first glance, the change looks quite straightforward and should hopefully be of low risk. Still the question is if we want to process this for the upcoming release given that we are short before M3 (and at least I will not have time to have a more thorough look into this until Thursday).