WIP - [GTK4] support Clipboard #2538
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 88 files - 30 88 suites - 30 7m 44s ⏱️ - 2m 32s Results for commit b300e03. ± Comparison against base commit 810cbcc. This pull request removes 37 tests.♻️ This comment has been updated with latest results. |
jonahgraham
force-pushed
the
clipboard
branch
from
40292bc to
bf0c317
Compare
This was referenced Sep 24, 2025
Merged
jonahgraham
force-pushed
the
clipboard
branch
from
bf0c317 to
7d94b02
Compare
|
I have split out some foundational work into the following PRs that can be reviewed now: |
jonahgraham
force-pushed
the
clipboard
branch
from
7d94b02 to
0bbfb8c
Compare
A number of places in the GTK4 API there is the possibility of passing in arrays of Strings, i.e. Java String[] -> char ** as input argument to C side. This change adds better support to the JNI generator for this use case by converting the jobjectArray (String[]) to char ** on the C side. Part of #2126 Split out of #2538
jonahgraham
force-pushed
the
clipboard
branch
from
0bbfb8c to
b300e03
Compare
akurtakov
pushed a commit
that referenced
this pull request
Sep 25, 2025
A number of places in the GTK4 API there is the possibility of passing in arrays of Strings, i.e. Java String[] -> char ** as input argument to C side. This change adds better support to the JNI generator for this use case by converting the jobjectArray (String[]) to char ** on the C side. Part of #2126 Split out of #2538
jonahgraham
added a commit
that referenced
this pull request
Sep 25, 2025
Testing the Clipboard can be difficult because there are a lot of system issues that can interfere, but of particular concern are: 1. System clipboard managers which may take ownership of the clipboard at unexpected times. 2. Limitations as to when processes can access clipboard, such as on Wayland where only active window can access clipboard. 3. Different behaviour when copying within a single process than between processes. These tests aim to resolve these issues. For the system clipboard manager there are a lot of extra sleep calls to allow clipboard manager to complete operations before continuing tests. In addition, we run all the tests multiple times by default to ensure stability. For the process limitations, we carefully control when the shell is created because we often cannot get focus back when shell ends up in the background. See the openAndFocusShell and openAndFocusRemote methods. For the different behaviours, we spin up a simple Swing app in a new process (the "remote" in openAndFocusRemote above). This app can be directed, over RMI, to access the clipboard. This allows our test to place data on the clipboard and ensure that the remote app can read the data successfully. For now this test only covers basic text (and a little of RTF). Adding Image and other transfers is part of the future work as such functionality is added in GTK4 while working on #2126 For the changes to SwtTestUtil that we required: 1. isGTK4 moved from Test_org_eclipse_swt_widgets_Shell.java to the Utils 2. processEvents was limited to 20 readAndDispatch calls per second due to the ordering of the targetTimestamp check. This change allows full speed readAndDispatching. 3. getPath was refactored to allow better control of source and destination of files extracted. See extracting of class files for remote Swing app in startRemoteClipboardCommands method Part of #2126 Split out of #2538
|
This was closed and will be replaced by a new PR - it was closed because I deleted my fork while trying to track down a git lfs issue I was having. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my "its sort of working" Clipboard for GTK4.
This PR is a draft and contains a bunch of TODOs, some are questions for myself, some are questions for others. There are a number of items in here I plan to pull into separate PRs, so this PR may not be so interesting to review yet. But if someone want to, they should be able to run the new test class Test_org_eclipse_swt_dnd_Clipboard to see basic functionality working. This test seems reliable on my machine on GTK3, but not so much on GTK4 yet.
Once complete this will:
Fixes #2126