Adding loadImageData(zoom) to the AbstractImageProvider Wrapper #2570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunjose696
force-pushed
the
arunjose696/loadImageDataToAbstract
branch
5 times, most recently
from
e440f64 to
8f3f17b
Compare
HeikoKlare
reviewed
Oct 1, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Show resolved
Hide resolved
arunjose696
force-pushed
the
arunjose696/loadImageDataToAbstract
branch
from
8f3f17b to
5ec4863
Compare
This refactoring is required to load unscaled ImageData for all wrappers The loadImageData for the added functions would have similar logic to newImageData() except the imageData returned would not be scaled but would be an ElementAtZoom
HeikoKlare
force-pushed
the
arunjose696/loadImageDataToAbstract
branch
from
5ec4863 to
f961dcd
Compare
akoch-yatta
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Changes look good to as preparatory work for #2526 and testing didn't show me any regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring is required to load unscaled ImageData for all wrappers The loadImageData for the added functions would have similar logic to newImageData() except the imageData returned would not be scaled but would be an ElementAtZoom.
This is required for #2526 (comment)