[GTK4] Implement Clipboard supporting copy and pasting to other applications #2588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 88 files - 27 88 suites - 27 8m 11s ⏱️ - 3m 53s Results for commit 28f4799. ± Comparison against base commit dfd19fc. This pull request removes 5 and adds 1 tests. Note that renamed tests count towards both.This pull request skips 3 tests.♻️ This comment has been updated with latest results. |
jonahgraham
force-pushed
the
clipboard
branch
3 times, most recently
from
929cde3 to
374db73
Compare
Obtaining data from the clipboard is fundamentally an asynchronous operation, the event loop, at least at the OS level, needs to run for the data to become available. This PR proposes new API that provides asynchronous equivalents of getContents methods called getContentsAsync that return CompleteableFutures. This new API will allow SWT API consumers to interact better with the clipboard when the OS (window system) API is actually implemented in an asynchronous manner. GTK3 and cocoa provides API that spins the event loop as needed so that a synchronous looking API can be provided to the user of the API. For example, in SWT we use gtk_clipboard_wait_for_contents which spins the loop in the GTK library itself [here](https://gitlab.gnome.org/GNOME/gtk/-/blob/716458e86a222f43e64f7a4feda37749f3469ee4/gtk/gtkclipboard.c#L1436) GTK4 does not provide such an API and leaves it to the user of the API to spin the event loop. Win32 is somewhat of a hybrid. The API appears synchronous, but SWT needs to spin in a couple of places, such as [getData](https://github.com/eclipse-platform/eclipse.platform.swt/blob/63e8925dc77db3b93ef521dc6cf2bd6ded7bab64/bundles/org.eclipse.swt/Eclipse%20SWT%20Drag%20and%20Drop/win32/org/eclipse/swt/dnd/Transfer.java#L46) Part of eclipse-platform#2598 and eclipse-platform#2126
jonahgraham
force-pushed
the
clipboard
branch
from
374db73 to
aac1268
Compare
…cations The pre-existing implementation of Clipboard for GTK4 only allowed copying and pasting within the application. Add 'clipboard' Tag to all tests that use it, and mark all suites as `failIfNoTests` = `false` so that tags are useful Fixes eclipse-platform#2126
jonahgraham
force-pushed
the
clipboard
branch
from
aac1268 to
28f4799
Compare
|
In addition the automated tests contained within this change the other ways to test this change involves manually running multiple instances of ClipboardExample (in SWT examples), in both GTK3 and GTK4 and ensuring that all types can be copied between instances. Using Testing has been done in GNOME, KDE and Xfce, both with clipboard managers disabled and enabled. Note: the parent commit of this PR is #2650 which is also waiting for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-existing implementation of Clipboard for GTK4 only allowed copying and pasting within the application.
Fixes #2126