Skip to content

Conversation

HeikoKlare
Copy link
Contributor

When drawing an image at a specified size, currently a new image handle is always created based on on-demand loaded image data. In case the fallback to loading image data for the best fitting zoom is used, a handle for that zoom may already exist and could be reused but is currently not considered.

With this change, an existing handle is used if appropriate instead of unnecessarily creating a temporary handle.

Copy link
Contributor

github-actions bot commented Oct 15, 2025

Test Results

  115 files  ±0    115 suites  ±0   11m 55s ⏱️ -19s
4 560 tests ±0  4 544 ✅ ±0  16 💤 ±0  0 ❌ ±0 
  311 runs  ±0    308 ✅ ±0   3 💤 ±0  0 ❌ ±0 

Results for commit c096306. ± Comparison against base commit cf6ee39.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare marked this pull request as ready for review October 15, 2025 16:00
When drawing an image at a specified size, currently a new image handle
is always created based on on-demand loaded image data. In case the
fallback to loading image data for the best fitting zoom is used, a
handle for that zoom may already exist and could be reused but is
currently not considered.

With this change, an existing handle is used if appropriate instead of
unnecessarily creating a temporary handle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reuse existing handles when drawing image at size

2 participants