Make TreeItem.getExpanded consistent across platforms #2834 #2836
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Test Results 118 files ±0 118 suites ±0 19m 12s ⏱️ + 2m 54s Results for commit 84bda53. ± Comparison against base commit cd186a7. This pull request skips 1 and un-skips 1 tests.♻️ This comment has been updated with latest results. |
ptziegler
force-pushed
the
issue2834
branch
4 times, most recently
from
6dbd06a to
f83432e
Compare
…m#2834 When the children of a previously expanded TreeItem are removed, the call to getExpanded() should continue to return "true". On both Linux and MacOS, this property is not persisted and therefore stored in a local variable. But on Linux, a call to getExpanded() still returns the result from a call to the GTK API. To harmonize the behavior between the different operating systems, following changes are done: 1) The call to getExpanded() now always returns the local variable, similar to how it's done for MacOS. 2) The call to setExpanded() doesn't modify the tree item if it is already expanded or a leaf node. Closes eclipse-platform#2834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the children of a previously expanded TreeItem are removed, the call to getExpanded() should continue to return "true". On both Linux and MacOS, this property is not persisted and therefore stored in a local variable. But on Linux, a call to getExpanded() still returns the result from a call to the GTK API.
To harmonize the behavior between the different operating systems, following changes are done:
The call to getExpanded() now always returns the local variable, similar to how it's done for MacOS.
The call to setExpanded() doesn't modify the tree item if it is already expanded or a leaf node.