Fixup warnings due to using deprecated JDK methods (in Examples only) #2837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
jonahgraham
force-pushed
the
deprecated-warnings-in-examples
branch
from
6eb93a3 to
1ff5065
Compare
jonahgraham
commented
Dec 2, 2025
| System.err.println("Some Snippets are still running:"); | ||
| for (Thread t : launchedSnippets) { | ||
| System.err.println(" " + t.getName() + " (ThreadId: " + t.getId() + ")"); | ||
| System.err.println(" " + t.getName() + " (ThreadId: " + t.threadId() + ")"); |
Contributor
Author
There was a problem hiding this comment.
This is the warning fix that can lead to error if JRE is incorrectly set to Java 17 as outlined here
Contributor
Author
|
The Jenkins build ran against #2838 and shows my whole collection of commits to remove warnings has been successful. As I don't think there is anything controversial or risky about this change I am merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to resolve new warnings due to update to Java21 #2824 is warning free.