Skip to content

Replacing usages of Image(Display, Rectangle) #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

ShahzaibIbrahim
Copy link
Contributor

@ShahzaibIbrahim ShahzaibIbrahim commented May 2, 2025

Replacing usages of Image(Display, Rectangle) in favor of Image(Display, int ,int) since the prior one is getting deprecated.

Note to myself (@fedejeanne): merge this PR before (or at least together with) eclipse-platform/eclipse.platform.swt#2088 so we don't see unnecessary warnings about deprecation/removal.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.workbench3/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 1c5fa94b861bf180e5928042df7e0a4114783721 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 2 May 2025 14:49:43 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.e4.ui.workbench3/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench3/META-INF/MANIFEST.MF
index 74fb453870..122b649236 100644
--- a/bundles/org.eclipse.e4.ui.workbench3/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench3/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench3;singleton:=true
-Bundle-Version: 0.17.400.qualifier
+Bundle-Version: 0.17.500.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented May 2, 2025

Test Results

 1 824 files  + 1 824   1 824 suites  +1 824   1h 31m 30s ⏱️ + 1h 31m 30s
 7 918 tests + 7 918   7 687 ✅ + 7 687  228 💤 +228  3 ❌ +3 
23 841 runs  +23 841  23 090 ✅ +23 090  748 💤 +748  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 6b9497e. ± Comparison against base commit 9e7f21f.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member

Replacing usages of Image(Display, Rectangle) in favor of Image(Display, int ,int) since the prior one is getting deprecated.

Is there already a PR for that?

ShahzaibIbrahim and others added 2 commits May 7, 2025 15:20
Replacing usages of Image(Display, Rectangle) in favor of Image(Display,
int ,int) since the prior one is getting deprecated.
Copy link
Contributor

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fedejeanne
Copy link
Contributor

Replacing usages of Image(Display, Rectangle) in favor of Image(Display, int ,int) since the prior one is getting deprecated.

Is there already a PR for that?

eclipse-platform/eclipse.platform.swt#2088

@fedejeanne
Copy link
Contributor

Failing tests are unrelated: #195, #1737

@fedejeanne fedejeanne merged commit 70a35a9 into eclipse-platform:master May 8, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamize Image constructors with Rectangle
4 participants