Skip to content

Add ZoomChanged listener to MessageDialogue #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+34 −1
Open

Add ZoomChanged listener to MessageDialogue #3212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.jface/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.jface;singleton:=true
Bundle-Version: 3.38.100.qualifier
Bundle-Version: 3.38.200.qualifier

Check warning on line 5 in bundles/org.eclipse.jface/META-INF/MANIFEST.MF

View check run for this annotation

Jenkins - Eclipse Platform / API Tools

MINOR_VERSION_CHANGE_NO_NEW_API 

ERROR:
The service version is increased unnecessarily since either the major or minor or service version is already increased
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Export-Package: org.eclipse.jface,
Expand Down
33 changes: 33 additions & 0 deletions bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/IconAndMessageDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.eclipse.swt.accessibility.AccessibleEvent;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.graphics.Point;
import org.eclipse.swt.graphics.Rectangle;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Display;
Expand Down Expand Up @@ -296,4 +297,36 @@ private Image getSWTImage(final int imageID) {

}

@Override
protected void configureShell(Shell shell) {
super.configureShell(shell);
if (shouldRecomputeSizeOnDpiChange()) {
shell.addListener(SWT.ZoomChanged, e -> recomputeShellSize(shell));
}
}

/**
* Default behavior: recompute size based on current shell keep the maximum
* among the current bounds and the computed bounds
*
*/
private void recomputeShellSize(Shell shell) {
Point newSize = shell.computeSize(SWT.DEFAULT, SWT.DEFAULT, false);
Rectangle currentBounds = shell.getBounds();
newSize.x = Math.max(currentBounds.width, newSize.x);
newSize.y = Math.max(currentBounds.height, newSize.y);
shell.setBounds(currentBounds.x, currentBounds.y, newSize.x, newSize.y);
}

/**
* This flag should be set to true if the size of this dialogue has to be
* recomputed on DPI change
*
* @return boolean
* @since 3.38
*/
public boolean shouldRecomputeSizeOnDpiChange() {
return false;
}

}
Loading