Skip to content

Clean Code for bundles/org.eclipse.core.databinding#3262

Merged
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.core.databinding
Sep 20, 2025
Merged

Clean Code for bundles/org.eclipse.core.databinding#3262
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.core.databinding

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 16, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 3d9a30bb6b6238303af211b7489222410e03ea23 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sat, 20 Sep 2025 02:41:12 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF b/bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF
index 6423ecb64b..12009435d8 100644
--- a/bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.databinding
-Bundle-Version: 1.13.600.qualifier
+Bundle-Version: 1.13.700.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.core.databinding;version="1.0.0",
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 16, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 24m 49s ⏱️ + 15m 27s
 8 017 tests ±0   7 772 ✅ +2  245 💤 ±0  0 ❌  - 2 
23 585 runs  ±0  22 803 ✅ +2  782 💤 ±0  0 ❌  - 2 

Results for commit 77fd524. ± Comparison against base commit ccafe58.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.core.databinding branch 4 times, most recently from 66ffe9b to ed59490 Compare September 19, 2025 02:41
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.core.databinding branch from b15f2d1 to 446adb3 Compare September 20, 2025 02:37
@akurtakov akurtakov merged commit 4e8711a into master Sep 20, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.core.databinding branch September 20, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants