Skip to content

Clean Code for bundles/org.eclipse.e4.ui.progress#3274

Merged
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.e4.ui.progress
Sep 20, 2025
Merged

Clean Code for bundles/org.eclipse.e4.ui.progress#3274
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.e4.ui.progress

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 17, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 6659c054f555d9165d80a225ca93b6338c487df5 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sat, 20 Sep 2025 03:03:19 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF
index 5d23feb14e..f730a368f2 100644
--- a/bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.progress;singleton:=true
-Bundle-Version: 0.4.800.qualifier
+Bundle-Version: 0.4.900.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 17, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 5m 45s ⏱️ - 3m 37s
 8 017 tests ±0   7 772 ✅ +2  245 💤 ±0  0 ❌  - 2 
23 585 runs  ±0  22 803 ✅ +2  782 💤 ±0  0 ❌  - 2 

Results for commit 60217bd. ± Comparison against base commit ccafe58.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.e4.ui.progress branch 3 times, most recently from 6d3001c to 1aff342 Compare September 19, 2025 03:04
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.e4.ui.progress branch from 745e1a8 to e1defab Compare September 20, 2025 02:58
@akurtakov akurtakov merged commit 153dc22 into master Sep 20, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.e4.ui.progress branch September 20, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants