Skip to content

Clean Code for bundles/org.eclipse.jface.databinding#3288

Merged
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.jface.databinding
Sep 25, 2025
Merged

Clean Code for bundles/org.eclipse.jface.databinding#3288
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.jface.databinding

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 18, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.jface.databinding/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b6a8cb36a2fe23c62e2efa63d54c5763f5ded42a Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 25 Sep 2025 03:41:41 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.jface.databinding/META-INF/MANIFEST.MF b/bundles/org.eclipse.jface.databinding/META-INF/MANIFEST.MF
index 381fa030b8..0e37dd244a 100644
--- a/bundles/org.eclipse.jface.databinding/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.jface.databinding/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jface.databinding
-Bundle-Version: 1.15.300.qualifier
+Bundle-Version: 1.15.400.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.jface.databinding.dialog,
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 4m 59s ⏱️ - 1h 58m 14s
 8 019 tests ±0   7 774 ✅ ±0  245 💤 ±0  0 ❌ ±0 
23 597 runs  +6  22 815 ✅ +6  782 💤 ±0  0 ❌ ±0 

Results for commit 1d89a07. ± Comparison against base commit edc2b90.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.databinding branch 7 times, most recently from 2c38e81 to 055fefc Compare September 24, 2025 03:26
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.databinding branch 2 times, most recently from 28797f3 to d731b36 Compare September 24, 2025 12:20
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.databinding branch from 0c7149b to dd44672 Compare September 25, 2025 03:37
@akurtakov akurtakov merged commit 8b0bfa8 into master Sep 25, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.jface.databinding branch September 25, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants