Skip to content

Conversation

eclipse-platform-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

Copy link
Contributor

github-actions bot commented Sep 19, 2025

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 23m 17s ⏱️ - 8m 35s
 8 215 tests ±0   7 966 ✅ ±0  249 💤 ±0  0 ❌ ±0 
23 565 runs  ±0  22 771 ✅ ±0  794 💤 ±0  0 ❌ ±0 

Results for commit 5a9b96f. ± Comparison against base commit 8ce2da8.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 9 times, most recently from 41d9bee to 03683f1 Compare September 25, 2025 03:41
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 03683f1 to ab6b8d6 Compare September 26, 2025 03:28
@akurtakov
Copy link
Member

@laeubi This is simply non reviewable (even according to Github UI). Is there a way to run smaller set of changes for this bundle or should it be done manually so we got a PR that can actually be reviewed?

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from ab6b8d6 to 88bee99 Compare September 27, 2025 03:25
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 88bee99 to d1391ba Compare September 27, 2025 11:15
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch 4 times, most recently from 7ea3aa8 to 3bf0879 Compare October 2, 2025 03:31
@vogella
Copy link
Contributor

vogella commented Oct 2, 2025

@akurtakov I think most of these changes are "Convert control statement bodies to block". I run this clean-up manually and push it in smaller batches so that this becomes reviewable.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.jface.text branch from 1defe6a to 5a9b96f Compare October 4, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants