Skip to content

Clean Code for bundles/org.eclipse.search#3302

Merged
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.search
Sep 22, 2025
Merged

Clean Code for bundles/org.eclipse.search#3302
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.search

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 20, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.search/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 3dd393d12a8d29be45803a2546f1db5621cd13d3 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 22 Sep 2025 03:48:28 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.search/META-INF/MANIFEST.MF b/bundles/org.eclipse.search/META-INF/MANIFEST.MF
index 001a2b22bf..521dc47cfe 100644
--- a/bundles/org.eclipse.search/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.search/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.search; singleton:=true
-Bundle-Version: 3.17.300.qualifier
+Bundle-Version: 3.17.400.qualifier
 Bundle-Activator: org.eclipse.search.internal.ui.SearchPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 20, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 0m 41s ⏱️ + 6m 26s
 8 017 tests ±0   7 772 ✅ +1  245 💤 ±0  0 ❌  - 1 
23 585 runs  ±0  22 803 ✅ +1  782 💤 ±0  0 ❌  - 1 

Results for commit 65ea4a1. ± Comparison against base commit 0cd325d.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.search branch from 8314ab5 to b123a7b Compare September 21, 2025 03:41
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.search branch from 4f7d9f2 to 33bae81 Compare September 22, 2025 03:43
@akurtakov akurtakov merged commit dc6b4a8 into master Sep 22, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.search branch September 22, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants