Skip to content

Clean Code for bundles/org.eclipse.ui.cocoa#3306

Merged
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.ui.cocoa
Sep 21, 2025
Merged

Clean Code for bundles/org.eclipse.ui.cocoa#3306
akurtakov merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.ui.cocoa

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.cocoa/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From db310679d4fb235391fa397cf6791ce685d04d3b Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sun, 21 Sep 2025 03:56:22 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.ui.cocoa/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.cocoa/META-INF/MANIFEST.MF
index 2d0929934f..a85d423488 100644
--- a/bundles/org.eclipse.ui.cocoa/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.cocoa/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %fragmentName
 Bundle-SymbolicName: org.eclipse.ui.cocoa;singleton:=true
-Bundle-Version: 1.3.200.qualifier
+Bundle-Version: 1.3.300.qualifier
 Bundle-Vendor: %providerName
 Fragment-Host: org.eclipse.ui;bundle-version="[3.5.0,4.0.0)"
 Bundle-Localization: fragment-cocoa
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 9m 18s ⏱️ + 15m 51s
 8 017 tests ±0   7 772 ✅ ±0  245 💤 ±0  0 ❌ ±0 
23 585 runs  ±0  22 803 ✅ ±0  782 💤 ±0  0 ❌ ±0 

Results for commit 2cbae33. ± Comparison against base commit 11aace0.

@akurtakov akurtakov merged commit 0cd325d into master Sep 21, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.ui.cocoa branch September 21, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants