Skip to content

Clean Code for bundles/org.eclipse.ui.ide.application#3312

Merged
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.ui.ide.application
Sep 24, 2025
Merged

Clean Code for bundles/org.eclipse.ui.ide.application#3312
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.ui.ide.application

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 23, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b0df6ea9f3a2d50e7d9136132fff23049a6729ff Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 24 Sep 2025 04:02:20 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
index 161698f8d9..8e8ed96585 100644
--- a/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.ide.application/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.ide.application;singleton:=true
-Bundle-Version: 1.5.800.qualifier
+Bundle-Version: 1.5.900.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.ui.ide;bundle-version="[3.21.0,4.0.0)",
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 23, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   1h 59m 14s ⏱️ - 5m 26s
 8 019 tests ±0   7 774 ✅ ±0  245 💤 ±0  0 ❌ ±0 
23 591 runs  ±0  22 809 ✅ ±0  782 💤 ±0  0 ❌ ±0 

Results for commit 56c559d. ± Comparison against base commit 422bd8b.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.ui.ide.application branch from db13ff7 to 449bb9e Compare September 24, 2025 03:57
@akurtakov akurtakov merged commit 207b8fe into master Sep 24, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.ui.ide.application branch September 24, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants