Skip to content

Clean Code for bundles/org.eclipse.ui.navigator.resources#3318

Merged
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.ui.navigator.resources
Sep 24, 2025
Merged

Clean Code for bundles/org.eclipse.ui.navigator.resources#3318
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.ui.navigator.resources

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 24, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 48d823cccaa77770d2a964838d09dedc1a018a69 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 24 Sep 2025 09:35:02 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
index 30277bf444..484bfaa8e9 100644
--- a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.navigator.resources; singleton:=true
-Bundle-Version: 3.9.800.qualifier
+Bundle-Version: 3.9.900.qualifier
 Bundle-Activator: org.eclipse.ui.internal.navigator.resources.plugin.WorkbenchNavigatorPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 24, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 6m 0s ⏱️ + 5m 9s
 8 019 tests ±0   7 774 ✅ +1  245 💤 ±0  0 ❌  - 1 
23 591 runs  ±0  22 809 ✅ +1  782 💤 ±0  0 ❌  - 1 

Results for commit f33665d. ± Comparison against base commit 36f81f0.

♻️ This comment has been updated with latest results.

@akurtakov akurtakov force-pushed the clean-code/bundles/org.eclipse.ui.navigator.resources branch from 7699e9f to 0bcad48 Compare September 24, 2025 05:57
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.ui.navigator.resources branch from 0bcad48 to fb391f4 Compare September 24, 2025 09:30
@akurtakov akurtakov merged commit 8ce075d into master Sep 24, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.ui.navigator.resources branch September 24, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants