Skip to content

Fix comments place in FormColors #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Sep 24, 2025
Merged

Fix comments place in FormColors #3319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 40 additions & 39 deletions bundles/org.eclipse.ui.forms/src/org/eclipse/ui/forms/FormColors.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 202 IBM Corporation and others.
* Copyright (c) 2000, 2025 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -519,30 +519,30 @@ private void createTitleBarOutlineColors() {
// title bar outline - border color
RGB tbBorder = getSystemColor(SWT.COLOR_WIDGET_LIGHT_SHADOW);
RGB bg = getImpliedBackground().getRGB();
// Group 1
// Rule: If at least 2 of the RGB values are equal to or between 180 and
// 255, then apply specified opacity for Group 1
// Examples: Vista, XP Silver, Wn High Con #2
// Keyline = TITLE_BACKGROUND @ 70% Opacity over LIST_BACKGROUND
if (testTwoPrimaryColors(tbBorder, 179, 256))
if (testTwoPrimaryColors(tbBorder, 179, 256)) {
// Group 1
// Rule: If at least 2 of the RGB values are equal to or between 180 and
// 255, then apply specified opacity for Group 1
// Examples: Vista, XP Silver, Wn High Con #2
// Keyline = TITLE_BACKGROUND @ 70% Opacity over LIST_BACKGROUND
tbBorder = blend(tbBorder, bg, 70);

// Group 2
// Rule: If at least 2 of the RGB values are equal to or between 121 and
// 179, then apply specified opacity for Group 2
// Examples: XP Olive, OSX Graphite, Linux GTK, Wn High Con Black
} else if (testTwoPrimaryColors(tbBorder, 120, 180)) {
// Group 2
// Rule: If at least 2 of the RGB values are equal to or between 121 and
// 179, then apply specified opacity for Group 2
// Examples: XP Olive, OSX Graphite, Linux GTK, Wn High Con Black

// Keyline = TITLE_BACKGROUND @ 50% Opacity over LIST_BACKGROUND
else if (testTwoPrimaryColors(tbBorder, 120, 180))
// Keyline = TITLE_BACKGROUND @ 50% Opacity over LIST_BACKGROUND
tbBorder = blend(tbBorder, bg, 50);

// Group 3
// Rule: Everything else
// Examples: XP Default, Wn Classic Standard, Wn Marine, Wn Plum, OSX
// Aqua, Wn High Con White, Wn High Con #1
} else {
// Group 3
// Rule: Everything else
// Examples: XP Default, Wn Classic Standard, Wn Marine, Wn Plum, OSX
// Aqua, Wn High Con White, Wn High Con #1

// Keyline = TITLE_BACKGROUND @ 30% Opacity over LIST_BACKGROUND
else {
// Keyline = TITLE_BACKGROUND @ 30% Opacity over LIST_BACKGROUND
tbBorder = blend(tbBorder, bg, 30);
}
createColor(FormColors.TB_BORDER, tbBorder);
Expand Down Expand Up @@ -586,32 +586,33 @@ private void createFormHeaderKeylineColors() {
// H_BOTTOM_KEYLINE1
createColor(IFormColors.H_BOTTOM_KEYLINE1, new RGB(255, 255, 255));

// H_BOTTOM_KEYLINE2
// Group 1
// Rule: If at least 2 of the RGB values are equal to or between 180 and
// 255, then apply specified opacity for Group 1
// Examples: Vista, XP Silver, Wn High Con #2
// Keyline = TITLE_BACKGROUND @ 70% Opacity over LIST_BACKGROUND
if (testTwoPrimaryColors(titleBg, 179, 256))
if (testTwoPrimaryColors(titleBg, 179, 256)) {
// H_BOTTOM_KEYLINE2
// Group 1
// Rule: If at least 2 of the RGB values are equal to or between 180 and
// 255, then apply specified opacity for Group 1
// Examples: Vista, XP Silver, Wn High Con #2
// Keyline = TITLE_BACKGROUND @ 70% Opacity over LIST_BACKGROUND
keyline2 = blend(titleBg, bg, 70);

// Group 2
// Rule: If at least 2 of the RGB values are equal to or between 121 and
// 179, then apply specified opacity for Group 2
// Examples: XP Olive, OSX Graphite, Linux GTK, Wn High Con Black
// Keyline = TITLE_BACKGROUND @ 50% Opacity over LIST_BACKGROUND
else if (testTwoPrimaryColors(titleBg, 120, 180))
} else if (testTwoPrimaryColors(titleBg, 120, 180)) {
// Group 2
// Rule: If at least 2 of the RGB values are equal to or between 121 and
// 179, then apply specified opacity for Group 2
// Examples: XP Olive, OSX Graphite, Linux GTK, Wn High Con Black
// Keyline = TITLE_BACKGROUND @ 50% Opacity over LIST_BACKGROUND
keyline2 = blend(titleBg, bg, 50);

// Group 3
// Rule: If at least 2 of the RGB values are equal to or between 0 and
// 120, then apply specified opacity for Group 3
// Examples: XP Default, Wn Classic Standard, Wn Marine, Wn Plum, OSX
// Aqua, Wn High Con White, Wn High Con #1
} else {
// Group 3
// Rule: If at least 2 of the RGB values are equal to or between 0 and
// 120, then apply specified opacity for Group 3
// Examples: XP Default, Wn Classic Standard, Wn Marine, Wn Plum, OSX
// Aqua, Wn High Con White, Wn High Con #1

// Keyline = TITLE_BACKGROUND @ 30% Opacity over LIST_BACKGROUND
else
// Keyline = TITLE_BACKGROUND @ 30% Opacity over LIST_BACKGROUND
keyline2 = blend(titleBg, bg, 30);
}
// H_BOTTOM_KEYLINE2
createColor(IFormColors.H_BOTTOM_KEYLINE2, keyline2);
}
Expand Down
Loading