Skip to content

Clean Code for bundles/org.eclipse.ui.win32#3324

Merged
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.ui.win32
Sep 25, 2025
Merged

Clean Code for bundles/org.eclipse.ui.win32#3324
akurtakov merged 2 commits into
masterfrom
clean-code/bundles/org.eclipse.ui.win32

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 24, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.win32/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From d930c19cf4fdbb2f7d5b52736177b3127461493e Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 25 Sep 2025 04:28:54 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.ui.win32/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.win32/META-INF/MANIFEST.MF
index 6095acf40f..5a6c98cc64 100644
--- a/bundles/org.eclipse.ui.win32/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.win32/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %fragmentName
 Bundle-SymbolicName: org.eclipse.ui.win32
-Bundle-Version: 3.5.300.qualifier
+Bundle-Version: 3.5.400.qualifier
 Bundle-Vendor: %providerName
 Fragment-Host: org.eclipse.ui.ide;bundle-version="[3.2.0,4.0.0)"
 Require-Bundle: org.eclipse.core.resources;resolution:=optional
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 24, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   2h 12m 18s ⏱️ - 1h 50m 55s
 8 019 tests ±0   7 774 ✅ ±0  245 💤 ±0  0 ❌ ±0 
23 597 runs  +6  22 815 ✅ +6  782 💤 ±0  0 ❌ ±0 

Results for commit 132fef5. ± Comparison against base commit edc2b90.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.ui.win32 branch from 38f44df to 54b50e2 Compare September 25, 2025 04:24
@akurtakov akurtakov merged commit 7dce6ab into master Sep 25, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.ui.win32 branch September 25, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants