Skip to content

Add detailed Copilot onboarding instructions for Eclipse Platform UI#3340

Merged
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:master
Oct 1, 2025
Merged

Add detailed Copilot onboarding instructions for Eclipse Platform UI#3340
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:master

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Oct 1, 2025

Provides an automated Copilot analysis to guide follow-up tasks. Includes validation steps and links to key documentation for easier setup
and future reference.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 1, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   1h 55m 18s ⏱️ - 4m 18s
 8 019 tests ±0   7 773 ✅ ±0  245 💤 ±0  1 ❌ ±0 
23 597 runs  ±0  22 814 ✅ ±0  782 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0c2eeb8. ± Comparison against base commit 27438b5.

♻️ This comment has been updated with latest results.

@laeubi laeubi requested a review from Copilot October 1, 2025 09:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive Copilot onboarding instructions for Eclipse Platform UI development. The documentation provides essential guidance for AI-assisted development including project structure, build limitations, testing patterns, and critical Eclipse/OSGi development rules.

  • Adds detailed documentation covering project structure, build system limitations, and development workflows
  • Includes critical patterns for SWT resource management, UI threading, and data binding
  • Provides validation steps and troubleshooting guidance for common development issues

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/copilot-instructions.md Outdated
fShell = new Shell(Display.getDefault());
// setup
}
@After
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace after @After annotation should be removed for consistency with code formatting standards.

Suggested change
@After
@After

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

// setup
}
@After
public void tearDown() { /* cleanup */ }
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The teardown method should include specific cleanup steps relevant to Eclipse UI testing, such as disposing shells and cleaning up display resources, rather than just a generic comment.

Suggested change
public void tearDown() { /* cleanup */ }
public void tearDown() {
if (fShell != null && !fShell.isDisposed()) {
fShell.dispose();
}
}

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit to specific, I will not apply that one.

Provides an automated Copilot analysis to guide follow-up tasks.
Includes validation steps and links to key documentation for easier
setup
and future reference.
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Oct 1, 2025

This is just an instruction file, so the test failure seem unrelated. Merging

@vogella vogella merged commit 458182a into eclipse-platform:master Oct 1, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants