Add syntax highlight to code blocks#3345
Conversation
|
@Mailaender thanks. @merks WDYT? |
|
Is such a "rendered" way deployed anywhere at all? |
I'm not sure I understand the question. Yes all the markdown content of all the project are rendered in the website. E.g., https://eclipse.dev/eclipse/markdown/?file=eclipse-platform/eclipse.platform.ui/master/docs
|
|
I don't really have time to review every line. May I trust that you've reviewed this content relatively carefully? |
|
I really missed the fact that all these markdown files are listed that way at https://eclipse.dev/eclipse/ . Thanks @merks ! |
|
One of the nice features too is that one can get a live preview of all your markdown changes (if you've used the Oomph setup for the website repository): https://eclipse.dev/eclipse/markdown/?f=news/instructions.md#markdown-preview |
|
I thought it good to record here that it should be possible do highlighting in the renderer too: https://www.npmjs.com/package/marked-highlight I just don't have the cycles for such work. |
|
I did all the changes manually, skimming through the code with Markdown preview enabled. Removed some stray new lines, and I also had trim whitespaces enabled in the editor, which is why this is a bit noisy. Sorry. |
|
💡 Pro-Tip for reviewers: https://github.com/eclipse-platform/eclipse.platform.ui/pull/3345/files?w=1 |
|
I went through the changes and havent' spotted anything wrong. Merging. |
|
Absolutely no need to apologize. I trust that you did a good job and I am grateful! 🙏 |



This creates nicer previews on GitHub and when reading documentation with @eclipse-theia.