Improve Contrast of Line Number Color#3387
Conversation
|
You can see the difference here: 
I made screenshots and zoomed it so that the difference more visible. |
| isEditable="false" | ||
| label="%dummy" | ||
| value="120,120,120"> | ||
| value="115,115,115"> |
There was a problem hiding this comment.
Couldn't we instead use a default system color constant instead, like COLOR_WIDGET_NORMAL_SHADOW_RGBA ? The OS usually makes good choice regarding accessibility. Relying on them by default would probably prevent current, and future, trouble.
There was a problem hiding this comment.
What's the value of COLOR_WIDGET_NORMAL_SHADOW_RGBA on the different OSes?
There was a problem hiding this comment.
The value depends on the theme used. One can run SWT's ControlExample - it has a tab that shows all these colors.
There was a problem hiding this comment.
On Linux it's 172,172,171 so actually brighter... But still, I don't think any color should be hardcoded, and we should instead rely on the OS, which may modify these values according to accessibility settings.
There was a problem hiding this comment.
177,172,171 is even worse:
So this does not help.
There was a problem hiding this comment.
Concretely, my experience having learned a bit how Gnome does its UI/UX decisions with real experts;
By the way: I was also working with a real (UX) expert from my team on that topic.
There was a problem hiding this comment.
let's agree on merging this one.
Let's say, I don't disagree on merging it. It's indeed not worse from the screenshot.
It looks like this color is not overridden by the dark theme. Have you checked it with dark theme? Should the dark theme color be adjusted too?
By the way: I was also working with a real (UX) expert from my team on that topic.
Then (out of curiosity), can you please ask them how come that this line numbers are a problem for other Gnome-based apps seem happy with a lighter color for line numbers?
Also, 1 other thing maybe worth challenging in the choice of color can be "why sticking to greyscale"? VSCode or Visual Studio seem to be using some dark cyan color and it looks nice, maybe the color is even derived from the COLOR_LINK_FOREGROUND system color.
That can be a good inspiration.
There was a problem hiding this comment.
It looks like this color is not overridden by the dark theme. Have you checked it with dark theme? Should the dark theme color be adjusted too?
I did check. It's overridden in the dark theme and contrast in the dark theme is ok.
There was a problem hiding this comment.
Also, 1 other thing maybe worth challenging in the choice of color can be "why sticking to greyscale"? VSCode or Visual Studio seem to be using some dark cyan color and it looks nice, maybe the color is even derived from the COLOR_LINK_FOREGROUND system color.
That can be a good inspiration.
I also checked VSCode. For VSCode there are a ton of themes and different themes do that differently. I also so that cyan-ish color but there are also themes that use a gresh-ish color.
I just wanted to stick to the "Eclipse way" and only make minimal changes.
There was a problem hiding this comment.
Then (out of curiosity), can you please ask them how come that this line numbers are a problem for other Gnome-based apps seem happy with a lighter color for line numbers?
What do you mean? You you please explain your question again?
Test Results 3 018 files 3 018 suites 2h 30m 39s ⏱️ Results for commit 74238d5. ♻️ This comment has been updated with latest results. |
BeckerWdf
force-pushed
the
lineNoColor
branch
from
a116d80 to
74238d5
Compare
4 participants
Fixes: #3385