Skip to content

Mark removal for unused deprecated methods/constants/classes in org.eclipse.ui.texteditor#3408

Merged
elsazac merged 1 commit into
eclipse-platform:masterfrom
deepika-u:markDeprecatedForRemoval
Oct 22, 2025
Merged

Mark removal for unused deprecated methods/constants/classes in org.eclipse.ui.texteditor#3408
elsazac merged 1 commit into
eclipse-platform:masterfrom
deepika-u:markDeprecatedForRemoval

Conversation

@deepika-u
Copy link
Copy Markdown
Contributor

@deepika-u deepika-u commented Oct 17, 2025

No description provided.

@deepika-u deepika-u force-pushed the markDeprecatedForRemoval branch from deba4aa to bdc31fc Compare October 17, 2025 09:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 17, 2025 •
edited
Loading

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 30m 13s ⏱️ + 1m 47s
 8 229 tests ±0   7 980 ✅ ±0  249 💤 ±0  0 ❌ ±0 
23 607 runs  ±0  22 813 ✅ ±0  794 💤 ±0  0 ❌ ±0 

Results for commit 2b9f683. ± Comparison against base commit aa146c3.

♻️ This comment has been updated with latest results.

@deepika-u deepika-u force-pushed the markDeprecatedForRemoval branch 2 times, most recently from b95c8b5 to 13fc1a8 Compare October 21, 2025 05:16
@deepika-u
Copy link
Copy Markdown
Contributor Author

deepika-u commented Oct 22, 2025

@akurtakov
Can you take a look when you get some time please?

akurtakov
akurtakov approved these changes Oct 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. I noticed that a good chunk of those are unused for very long period but implementors could have missed that so it's actually good to point that.

@deepika-u
Copy link
Copy Markdown
Contributor Author

deepika-u commented Oct 22, 2025

@akurtakov
Thanks for your time and opinion on this. I too saw some apis from "Show Revision Information" marked for deletion abit long ago. Felt like worth deleting but since anyways we waited so long not deleting them why now deviate from process. We'll mark for deletion first, then delete would be ideal i felt and proceeded with marking them for deletion.

Any other changes - do you suggest on these changes to be specific?

@akurtakov
Copy link
Copy Markdown
Member

akurtakov commented Oct 22, 2025

Please merge, nothing else from me.

@deepika-u
Copy link
Copy Markdown
Contributor Author

deepika-u commented Oct 22, 2025

I dont have merge access, can you please take it forward please. Thanks alot.

@deepika-u deepika-u force-pushed the markDeprecatedForRemoval branch 2 times, most recently from 82cca16 to afb0da8 Compare October 22, 2025 09:04
@elsazac elsazac force-pushed the markDeprecatedForRemoval branch from afb0da8 to 2b9f683 Compare October 22, 2025 11:34
@elsazac
Copy link
Copy Markdown
Member

elsazac commented Oct 22, 2025

Test looks good; Merging this now.

@elsazac elsazac merged commit e900fff into eclipse-platform:master Oct 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akurtakov akurtakov akurtakov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deepika-u @akurtakov @elsazac