Migrate JUnit 4 tests to JUnit 5 in org.eclipse.text.tests#3411
Conversation
Test Results 3 018 files 3 018 suites 2h 20m 50s ⏱️ Results for commit fd4a5b8. ♻️ This comment has been updated with latest results. |
efe351b to
9e47852
Compare
449ef4a to
64ebd0e
Compare
fedejeanne
left a comment
There was a problem hiding this comment.
The changes LGTM but I see this error in the logs:
Error: Please always use rebase to update your branch
Infrastructure problem?
Also, the GH bot says this PR removes tests. I hope the information is outdated. One can only double-check that when the tests finish running.
64ebd0e to
7ced97e
Compare
|
@fedejeanne I pushed a new change set with the changes, lets see if that fix the "removed lots of tests" message. |
|
Hm, the message is still there, but I think I know why (at least in part): some tests require |
e952cf2 to
8c5a776
Compare
|
@fedejeanne should be fine now, I plan to merge this in the next days until I hear more feedback. |
org.eclipse.jface.text.tests
8c5a776 to
fd4a5b8
Compare
No description provided.