Migrate org.eclipse.jface.tests.notifications from JUnit 4 to JUnit 5#3415
Merged
akurtakov merged 1 commit intoOct 20, 2025
Merged
Conversation
This commit migrates the org.eclipse.jface.tests.notifications test bundle from JUnit 4 to JUnit 5. Changes: - Updated imports from org.junit.* to org.junit.jupiter.api.* - Replaced @before with @beforeeach - Replaced @after with @AfterEach - Changed test class from public to package-private (JUnit 5 best practice) - Changed all test methods from public to package-private - Removed org.junit dependency from MANIFEST.MF - Added org.hamcrest Import-Package (previously provided by org.junit bundle) Test Results: - All 5 tests passing (10 total including suite execution) - Compilation successful - No functional changes to test logic Files modified: - NotificationPopupTest.java 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit migrates the org.eclipse.jface.tests.notifications test bundle from JUnit 4 to JUnit 5.
Changes:
Test Results:
Files modified:
🤖 Generated with Claude Code