Allow reuse of last opened editor via Project Explorer#3458
Closed
sebthom wants to merge 5 commits into
Closed
Conversation
sebthom
force-pushed
the
reuse-last-opened-editor
branch
from
cd4ffb6 to
006f657
Compare
Contributor
sebthom
force-pushed
the
reuse-last-opened-editor
branch
from
49e8d6e to
7b0069f
Compare
Adds `OpenFileWithReuseActionProvider` that wraps the current OPEN handler (dependsOn org.eclipse.jdt.ui.navigator.actions.OpenActions) and installs a wrapper OPEN action in Project Explorer. For single IFile selections (pref enabled), reuse the last editor via `OpenFileWithReuseAction`. For all other selections (e.g., IJavaElement), delegate to the previously installed OPEN handler (JDT's OpenAction), preserving Java behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the ability to optionally reuse the last opened editor (if non-dirty) when opening files from the Project Explorer. This has a similar UX to opening files from the search result view and when single click mode is enabled how vscode opens files.
This PR addresses #1692
When the JDT Plugin is installed in Eclipse it "hijacks" the OpenActions provider and file opening goes through
org.eclipse.jdt.internal.ui.navigator.PackageExplorerOpenActionProviderinstead oforg.eclipse.ui.internal.navigator.resources.actions.OpenActionProviderwhich does not apply the new logic. Therefore I added/configured an OpenFileWithReuseActionProvider that depends on the provider of the JDT (i.e. only activates when JDT is present) and wraps it so that opening of IFile is handled as expected.