Mark several unused deprecated methods/constants/classes in org.eclipse.jface package for removal #3467
+30
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepika-u
force-pushed
the
deprecated_constants3
branch
3 times, most recently
from
bc66787 to
614510a
Compare
merks
requested changes
Oct 31, 2025
| */ | ||
| @Deprecated | ||
| @Deprecated(forRemoval = true, since = "2025-12") | ||
| protected Label getErrorMessageLabel() { |
There was a problem hiding this comment.
This is kind of odd because it doesn't actually specify a replacement and there is no replacement.
There was a problem hiding this comment.
oh ok. So reverting this change.
But how do i get to understand it is not supposed to be marked for removal? Because i dont see any references as such for this.
deepika-u
force-pushed
the
deprecated_constants3
branch
from
614510a to
b6f588e
Compare
deepika-u
force-pushed
the
deprecated_constants3
branch
from
b6f588e to
75c1bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.