Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

A workaround for unexpected text wrapping in ExpandableComposite had been introduced to deal with imprecise size calculation of controls for zooms like 125% and 175%. With recent changes to SWT, the size calculation for controls has been improved such that they always allocate sufficient space to fit their contents in. That makes the workaround in ExpandableComposite obsolete.

This change thus removes the obsolete, temporary workaround introduced with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 8m 44s ⏱️ - 6m 41s
 8 236 tests ±0   7 987 ✅ +1  249 💤 ±0  0 ❌  - 1 
23 628 runs  ±0  22 834 ✅ +1  794 💤 ±0  0 ❌  - 1 

Results for commit b12e88c. ± Comparison against base commit 2d4334f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@arunjose696 arunjose696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with zoom levels 125, 150, 175, and 250. The issue that previously required a workaround is no longer present. It can be observed that using pixelToPointAsSufficientlyLargeSize to calculate sizes which performs rounding up resolves the issue.
If RoundingMode.Round is used in pixelToPointAsSufficientlyLargeSize, the issue can reappear without the workaround. This confirms that the current approach fixes the problem. So approving this revert.

@arunjose696 arunjose696 linked an issue Nov 26, 2025 that may be closed by this pull request
A workaround for unexpected text wrapping in ExpandableComposite had
been introduced to deal with imprecise size calculation of controls for
zooms like 125% and 175%. With recent changes to SWT, the size
calculation for controls has been improved such that they always
allocate sufficient space to fit their contents in. That makes the
workaround in ExpandableComposite obsolete.

This change thus removes the obsolete workaround.
@HeikoKlare HeikoKlare force-pushed the revert-workaround-expandablecomposite branch from 735af70 to 4e4fdcb Compare December 1, 2025 13:49
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.forms/META-INF/MANIFEST.MF

Warning

🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit.

Git patch
From 84fbebc8ef17345ceb2401a9a40bdd1548b07c15 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 1 Dec 2025 13:56:12 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/bundles/org.eclipse.ui.forms/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.forms/META-INF/MANIFEST.MF
index 0e03748813..97a3ce97c0 100644
--- a/bundles/org.eclipse.ui.forms/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.forms/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.ui.forms;singleton:=true
-Bundle-Version: 3.13.700.qualifier
+Bundle-Version: 3.13.800.qualifier
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
 Export-Package: org.eclipse.ui.forms,
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

@HeikoKlare HeikoKlare merged commit 1cffef2 into eclipse-platform:master Dec 3, 2025
21 of 22 checks passed
@HeikoKlare HeikoKlare deleted the revert-workaround-expandablecomposite branch December 3, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert workaround in ExpandableComposite

3 participants