Remove round tabs support from CTabRendering#3822
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
4a87569 to
da1c273
Compare
da1c273 to
594bfc8
Compare
This looks familiar to me. How did the version before look like? |
|
The same (screenshots prove that nothing broke) |
8747543 to
abebc2b
Compare
Removes the CSS-based rounded tab rendering feature from CTabRendering. This includes the swt-corner-radius CSS property, the CirclePart enum and circle drawing methods, the cornerSize field, and all round-tab rendering branches in drawTabBody, drawSelectedTab, and drawUnselectedTab. Also removes the USE_ROUND_TABS preference, the corresponding UI checkbox in ViewsPreferencePage, and the CSSPropertyCornerRadiusSWTHandler class. Fixes eclipse-platform#3806 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6c9bf6f to
1df300e
Compare
For user's that have set the now removed setting, the UI will change significantly. We should document this in the N&N. |
HeikoKlare
left a comment
There was a problem hiding this comment.
Nice code simplification coming with the removal of rounded tabs support. Thank you.
| Bundle-ManifestVersion: 2 | ||
| Bundle-SymbolicName: org.eclipse.e4.ui.css.swt;singleton:=true | ||
| Bundle-Version: 0.16.0.qualifier | ||
| Bundle-Version: 0.16.100.qualifier |
There was a problem hiding this comment.
In my opinion, this kind of change should have a minor version bump (at least in the og.eclipse.e4.ui.workbench.renderers.swt, maybe also in the org.eclipse.e4.ui.css.swt one).
1df300e to
1517b62
Compare
1517b62 to
c9c7459
Compare


Summary
swt-corner-radius) fromCTabRenderingCSSPropertyCornerRadiusSWTHandlerand removes itsplugin.xmlregistrationsetCornerRadius()fromICTabRenderinginterfaceUSE_ROUND_TABSpreference constant, the preference checkbox inViewsPreferencePage, and all related message stringsdrawTabBody,drawSelectedTab,drawUnselectedTab) to square-corner-only paths, removing theCirclePartenum and circle-drawing methodsCloses #3806
Test plan
🤖 Generated with Claude Code