Remove swt-simple CSS property support (curved tabs removed in SWT)#3853
Remove swt-simple CSS property support (curved tabs removed in SWT)#3853vogella wants to merge 1 commit into
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Test Results 852 files ±0 852 suites ±0 54m 33s ⏱️ ±0s For more details on these failures, see this check. Results for commit 6b08cd3. ± Comparison against base commit 2928a67. ♻️ This comment has been updated with latest results. |
f034e95 to
6b08cd3
Compare
CTabFolder.setSimple() is now deprecated and a no-op in SWT since curved tabs are no longer supported. Remove the CSS property handler registration from plugin.xml, drop swt-simple: false from e4_default_gtk.css, fix a pre-existing reflection bug in CTabRendering (wrong field name string), and update the test and docs accordingly.
6b08cd3 to
bfb7308
Compare
Summary
swt-simpleCSS property handler registration fromplugin.xml—CTabFolder.setSimple()is now deprecated and a no-op in SWT since curved tab support was removedswt-simple: falsefrome4_default_gtk.css(dead configuration)CTabRendering: field lookup used wrong string"selectionGradientColorsField"instead of"selectionGradientColors"CTabFolderTestto reflect thatgetSimple()always returnstruedocs/CSS.mdto documentswt-simpleas deprecatedRelated
Follows the SWT changes that removed curved tab support from
CTabFolderandCTabFolderRenderer.Test plan
org.eclipse.e4.ui.tests.css.swt—CTabFolderTest#testCTabFolderSimpleshould passorg.eclipse.e4.ui.workbench.renderers.swt