Skip to content

Add ToolControlRendererTest for ToolControlRenderer#3890

Merged
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:fix/tool-control-renderer-pack
Apr 17, 2026
Merged

Add ToolControlRendererTest for ToolControlRenderer#3890
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:fix/tool-control-renderer-pack

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Apr 14, 2026

Summary

Adds unit tests for ToolControlRenderer covering its core behavior:

  • Widget creation – verifies a widget is created for a MToolControl contribution
  • Empty contribution – verifies widget is null when the contribution creates no SWT children
  • HIDDEN_EXPLICITLY tag – verifies visibility is toggled when the tag is added/removed
  • HIDEABLE context menus – verifies each HIDEABLE control gets its own independent menu instance

No production code changes. This is a test-only PR.

Test plan

  • Run mvn clean verify -pl :org.eclipse.e4.ui.tests -Pbuild-individual-bundles -Dtest=ToolControlRendererTest — all 5 tests must pass

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

examples/org.eclipse.jface.examples.databinding/META-INF/MANIFEST.MF
examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 6279c5b9ddf68b0659fbd99c37f70d1b3ee7a2b1 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Tue, 14 Apr 2026 13:29:26 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/examples/org.eclipse.jface.examples.databinding/META-INF/MANIFEST.MF b/examples/org.eclipse.jface.examples.databinding/META-INF/MANIFEST.MF
index 26664654b7..98f5daa860 100644
--- a/examples/org.eclipse.jface.examples.databinding/META-INF/MANIFEST.MF
+++ b/examples/org.eclipse.jface.examples.databinding/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jface.examples.databinding
-Bundle-Version: 1.5.0.qualifier
+Bundle-Version: 1.5.100.qualifier
 Eclipse-BundleShape: dir
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF b/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF
index 70f52c76fd..29a64b5365 100644
--- a/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF
+++ b/examples/org.eclipse.ui.examples.javaeditor/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.examples.javaeditor; singleton:=true
-Bundle-Version: 3.5.0.qualifier
+Bundle-Version: 3.5.100.qualifier
 Bundle-Activator: org.eclipse.ui.examples.javaeditor.JavaEditorExamplePlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 14, 2026

Test Results

   852 files  ± 0     852 suites  ±0   55m 39s ⏱️ + 1m 22s
 7 899 tests + 5   7 656 ✅ + 5  243 💤 ±0  0 ❌ ±0 
20 199 runs  +15  19 544 ✅ +15  655 💤 ±0  0 ❌ ±0 

Results for commit 2f52816. ± Comparison against base commit 1146cf2.

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the fix/tool-control-renderer-pack branch from fa378b3 to 6e4d1de Compare April 15, 2026 15:42
@vogella vogella changed the title Fix ToolControlRenderer inflating toolbar via pack() side effect Add ToolControlRendererTest for ToolControlRenderer Apr 15, 2026
@vogella vogella marked this pull request as ready for review April 15, 2026 15:42
@vogella vogella force-pushed the fix/tool-control-renderer-pack branch from 6e4d1de to 9229009 Compare April 16, 2026 18:44
Adds unit tests covering the core behavior of ToolControlRenderer:
- Widget creation for MToolControl contributions
- Null widget when contribution creates no SWT children
- HIDDEN_EXPLICITLY tag toggling visibility
- Restoring visibility when HIDDEN_EXPLICITLY is removed
- Independent context menus for HIDEABLE controls

No production code changes.
@vogella vogella force-pushed the fix/tool-control-renderer-pack branch from 9229009 to 2f52816 Compare April 17, 2026 03:40
@vogella vogella merged commit 7f7e4b6 into eclipse-platform:master Apr 17, 2026
18 checks passed
@vogella vogella deleted the fix/tool-control-renderer-pack branch April 17, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants