Skip to content

Use ILog.of(Class) in org.eclipse.ui.ide #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 1 commit into from
Apr 20, 2026
Merged

Use ILog.of(Class) in org.eclipse.ui.ide #3907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...es/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/CopyFilesAndFoldersOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
import org.eclipse.core.resources.WorkspaceJob;
import org.eclipse.core.runtime.Adapters;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.ILog;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
Expand Down Expand Up @@ -644,10 +645,9 @@ protected boolean isMove() {
private void display(InvocationTargetException e) {
// CoreExceptions are collected above, but unexpected runtime
// exceptions and errors may still occur.
IDEWorkbenchPlugin.getDefault().getLog().log(
Status.error(MessageFormat.format(
"Exception in {0}.performCopy(): {1}", //$NON-NLS-1$
getClass().getName(), e.getTargetException())));
ILog.of(CopyFilesAndFoldersOperation.class).error(MessageFormat.format(
"Exception in {0}.performCopy(): {1}", //$NON-NLS-1$
getClass().getName(), e.getTargetException()));
displayError(NLS
.bind(
IDEWorkbenchMessages.CopyFilesAndFoldersOperation_internalError,
Expand Down
3 changes: 2 additions & 1 deletion ...g.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/EditorAssociationOverrideDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IConfigurationElement;
import org.eclipse.core.runtime.IExtensionRegistry;
import org.eclipse.core.runtime.ILog;
import org.eclipse.core.runtime.ISafeRunnable;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Platform;
Expand Down Expand Up @@ -160,7 +161,7 @@ private static EditorAssociationOverrideDescriptor[] createDescriptors(IConfigur
} else {
String message= MessageFormat.format(IDEWorkbenchMessages.editorAssociationOverride_error_invalidElementName_message,
configElement.getContributor().getName(), configElement.getName());
IDEWorkbenchPlugin.getDefault().getLog().log(new Status(IStatus.ERROR, IDEWorkbenchPlugin.IDE_WORKBENCH, IStatus.OK, message, null));
ILog.of(EditorAssociationOverrideDescriptor.class).error(message);
}
}
return result.toArray(new EditorAssociationOverrideDescriptor[result.size()]);
Expand Down
11 changes: 5 additions & 6 deletions bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ProjectNaturesPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.eclipse.core.resources.IWorkspace;
import org.eclipse.core.runtime.Adapters;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.ILog;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.jface.dialogs.ErrorDialog;
Expand Down Expand Up @@ -128,10 +129,9 @@ protected Control createContents(final Composite parent) {
this.naturesIdsWorkingCopy = new ArrayList<>();
this.naturesIdsWorkingCopy.addAll(Arrays.asList(project.getDescription().getNatureIds()));
} catch (CoreException ex) {
IDEWorkbenchPlugin.getDefault().getLog().log(new Status(IStatus.WARNING,
IDEWorkbenchPlugin.getDefault().getBundle().getSymbolicName(),
ILog.of(ProjectNaturesPage.class).warn(
"Error while loading project description for " + this.project.getName(), //$NON-NLS-1$
ex));
ex);
}
this.activeNaturesList.setInput(this.naturesIdsWorkingCopy);

Expand Down Expand Up @@ -313,10 +313,9 @@ public boolean performOk() {
try {
originalNatureIds = Arrays.asList(this.project.getDescription().getNatureIds());
} catch (CoreException ex) {
IDEWorkbenchPlugin.getDefault().getLog().log(new Status(IStatus.WARNING,
IDEWorkbenchPlugin.getDefault().getBundle().getSymbolicName(),
ILog.of(ProjectNaturesPage.class).warn(
"Error while loading project description for " + this.project.getName(), //$NON-NLS-1$
ex));
ex);
originalNatureIds = new ArrayList<>();
}
if (this.naturesIdsWorkingCopy.size() == originalNatureIds.size()
Expand Down
3 changes: 2 additions & 1 deletion ....eclipse.ui.ide/src/org/eclipse/ui/internal/ide/filesystem/FileSystemSupportRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.eclipse.core.runtime.IConfigurationElement;
import org.eclipse.core.runtime.IExtension;
import org.eclipse.core.runtime.IExtensionPoint;
import org.eclipse.core.runtime.ILog;
import org.eclipse.core.runtime.ISafeRunnable;
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.SafeRunner;
Expand Down Expand Up @@ -161,7 +162,7 @@ public void run() {

} catch (CoreException exception) {
exceptions[0] = exception;
IDEWorkbenchPlugin.getDefault().getLog().log(exception.getStatus());
ILog.of(FileSystemSupportRegistry.class).log(exception.getStatus());
}
}

Expand Down
3 changes: 2 additions & 1 deletion .../org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/MarkerContentGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import org.eclipse.core.resources.mapping.ResourceMapping;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IConfigurationElement;
import org.eclipse.core.runtime.ILog;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.jface.preference.IPreferenceStore;
import org.eclipse.jface.util.IPropertyChangeListener;
Expand Down Expand Up @@ -526,7 +527,7 @@ private void writeFiltersPreference() {
try {
memento.save(writer);
} catch (IOException e) {
IDEWorkbenchPlugin.getDefault().getLog().log(Util.errorStatus(e));
ILog.of(MarkerContentGenerator.class).log(Util.errorStatus(e));
}
// TODO: We need to migrate this the current class
IDEWorkbenchPlugin.getDefault().getPreferenceStore().putValue(
Expand Down
10 changes: 3 additions & 7 deletions ...s/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@
import org.eclipse.core.runtime.IConfigurationElement;
import org.eclipse.core.runtime.IExtension;
import org.eclipse.core.runtime.IExtensionPoint;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.ILog;
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.dynamichelpers.ExtensionTracker;
import org.eclipse.core.runtime.dynamichelpers.IExtensionChangeHandler;
import org.eclipse.core.runtime.dynamichelpers.IExtensionTracker;
Expand Down Expand Up @@ -572,11 +571,8 @@ private ProblemFilter newFilter(IConfigurationElement element) {
if (markerId != null) {
MarkerType markerType = filter.getMarkerType(markerId);
if (markerType == null) {
IStatus status = new Status(IStatus.WARNING, IDEWorkbenchPlugin.IDE_WORKBENCH, IStatus.WARNING,
NLS.bind(MarkerMessages.ProblemFilterRegistry_nullType,
new Object[] { markerId, filter.getName() }),
null);
IDEWorkbenchPlugin.getDefault().getLog().log(status);
ILog.of(MarkerSupportRegistry.class).warn(NLS.bind(MarkerMessages.ProblemFilterRegistry_nullType,
new Object[] { markerId, filter.getName() }));
} else {
selectedTypes.add(markerType);
}
Expand Down
Loading