Use ILog.of(Class) in PositionTracker and SmartImportTests#3909
Merged
akurtakov merged 1 commit intoApr 20, 2026
Merged
Conversation
Replace Plugin.getDefault().getLog().log(new Status(...)) with ILog.of(Class).error(...)/info(...). Drops the Activator round-trip and the Status allocation in one go. Log channel stays in the same bundle in both cases.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin.getDefault().getLog().log(new Status(...))withILog.of(Class).error(...)/.info(...)in two simple sites.Statusallocation in one go.Sites
PositionTracker(org.eclipse.search): error log, same-bundleSearchPluginremoved along with unusedIStatus/Statusimports.SmartImportTests(org.eclipse.ui.tests): info log, same-bundleTestPluginremoved along with unusedStatusimport.Log channel stays in the same bundle in both cases, so no behavior change.
Context: follow-up to the
ILog.of(Class)migration suggested at https://github.com/vogellacompany/tasks/issues/1837#issuecomment-4275267304. Kept intentionally small — workbench bundle sites and cross-bundle sites (e.g.ProjectEncodingMarkerResolutionGeneratorlogging throughUIPlugin) are deferred.Test plan
mvn clean compile -pl :org.eclipse.search -Pbuild-individual-bundlessucceedsmvn clean compile -pl :org.eclipse.ui.tests,:org.eclipse.jface.tests -Pbuild-individual-bundles -amsucceeds