Skip to content

Improve import dialog with column sorting and better visibility#3921

Merged
vogella merged 1 commit into
eclipse-platform:masterfrom
SougandhS:improveIMPORT
Apr 22, 2026
Merged

Improve import dialog with column sorting and better visibility#3921
vogella merged 1 commit into
eclipse-platform:masterfrom
SougandhS:improveIMPORT

Conversation

@SougandhS
Copy link
Copy Markdown
Contributor

Improves the import dialog usability by adding column-based sorting for the “Folder” and “Import As” columns (with ascending/descending toggle on header click) and increasing the proposals list height to display more entries by default. This aligns sorting with the displayed column values and makes it easier to scan and organize import proposals, especially when dealing with many entries, reducing the need for manual resizing.

Video.mp4

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Test Results

   852 files  ±0     852 suites  ±0   58m 23s ⏱️ + 9m 3s
 7 913 tests ±0   7 670 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 241 runs  ±0  19 586 ✅ ±0  655 💤 ±0  0 ❌ ±0 

Results for commit d5ac23e. ± Comparison against base commit d0eb817.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Apr 22, 2026

Nice improvement, thanks for working on this. Two small things worth addressing before merge:

  1. Clicking the already sorted "Folder" column flips the direction on the very first click, because the comparator is initialized with column = 0 and then setColumn(0) treats it as a repeat click. Users usually expect the first click
    to sort ascending. Consider starting the comparator in an "unset" state (for example column = -1) so the first click lands on ascending.

  2. ImportsComparator can be private static. It does not capture any state from SmartImportRootWizardPage (the label provider is passed in via the constructor), so there is no need for the implicit outer reference.

@SougandhS SougandhS force-pushed the improveIMPORT branch 2 times, most recently from a93c192 to a6d91ae Compare April 22, 2026 12:50
@SougandhS
Copy link
Copy Markdown
Contributor Author

Nice improvement, thanks for working on this.

Thanks !

Two small things worth addressing before merge:

Done 👍

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Apr 22, 2026

New observations:

  1. Default-sort regression — column = -1 means the comparator returns 0 on open, so the tree is unsorted while the Folder column still shows a sort indicator (because setSortColumn(folderCol) runs unconditionally during setup).
  2. heightHint = 190 — more than 2× the previous value; worth verifying on minimum screen size.
  3. NPE risk — projectLP.getText(f1) in case 1 isn't null-guarded.

Add sorting support for “Folder” and “Import As” columns, and increase
the proposals list height to display more entries without requiring
manual resizing.
@SougandhS
Copy link
Copy Markdown
Contributor Author

SougandhS commented Apr 22, 2026

  1. Default-sort regression — column = -1 means the comparator returns 0 on open, so the tree is unsorted while the Folder column still shows a sort indicator (because setSortColumn(folderCol) runs unconditionally during setup).

Made few tweaks - Fixed 👍

  1. heightHint = 190 — more than 2× the previous value; worth verifying on minimum screen size.

Adjusted it to 150 - I hope its good. with 90 I can see only 4 or 5 items by default.

  1. NPE risk — projectLP.getText(f1) in case 1 isn't null-guarded.

Added a guard

@vogella vogella merged commit fc4799a into eclipse-platform:master Apr 22, 2026
18 checks passed
@SougandhS
Copy link
Copy Markdown
Contributor Author

Thank you @vogella for the review and merging 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants