Show filename in Quick Diff progress job label#3931
Merged
vogella merged 1 commit intoApr 24, 2026
Conversation
The DocumentLineDiffer background job is currently labelled "Initializing Quick Diff" for every editor, which is misleading: the job also re-runs on every save and on reference changes, and identical labels give no hint which editor a given entry belongs to. Use the editor input name to produce a more informative label "Quick Diff: comparing <filename>" when available; fall back to the generic label otherwise.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DocumentLineDifferbackground job is currently labelled "Initializing Quick Diff" for every editor. The name is misleading because the job is not a one-time initialization (it also re-runs on every save and whenever the reference document changes), and identical labels give no hint which editor each Progress view entry belongs to.This change passes the editor input name into the differ so the job appears as "Quick Diff: comparing " when a name is available, falling back to the generic label otherwise.
DocumentLineDifferis internal, so the new setter is not API;IEditorInput.getName()is existing API.