Skip to content

Drop dead log(Exception) helper in WorkbenchActivitySupport #3935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 1 commit into from
Apr 24, 2026
Merged

Drop dead log(Exception) helper in WorkbenchActivitySupport #3935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions ...i.workbench/eclipseui/org/eclipse/ui/internal/activities/ws/WorkbenchActivitySupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import org.eclipse.core.runtime.IExtensionPoint;
import org.eclipse.core.runtime.IProduct;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.dynamichelpers.ExtensionTracker;
import org.eclipse.core.runtime.dynamichelpers.IExtensionChangeHandler;
Expand Down Expand Up @@ -55,7 +54,6 @@
import org.eclipse.ui.internal.WorkbenchWindow;
import org.eclipse.ui.internal.activities.MutableActivityManager;
import org.eclipse.ui.internal.activities.ProxyActivityManager;
import org.eclipse.ui.internal.misc.StatusUtil;
import org.eclipse.ui.internal.registry.IWorkbenchRegistryConstants;

/**
Expand Down Expand Up @@ -229,22 +227,15 @@ private void updateManager(final IContributionManager manager) {
try {
dialog.run(false, false, runnable);
} catch (InvocationTargetException | InterruptedException e2) {
log(e2);
// ModalContext.run uses InterruptedException to signal
// cancellation rather than actual thread interruption, so
// we do not re-set the interrupt flag here.
}
}));
}
}
}
}

/**
* Logs an error message to the workbench log.
*
* @param e the exception to log
*/
private void log(Exception e) {
StatusUtil.newStatus(IStatus.ERROR, "Could not update contribution managers", e); //$NON-NLS-1$
}
});
}

Expand Down
Loading