Revert "Defer expensive project reference computation during selection changes"#3942
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom Apr 29, 2026
Merged
Conversation
…n changes" This reverts commit 3aaea37e05f6d0e2ff90db5b2030dca8b1a98c83 and the follow-up Javadoc fix in 3b23ac5. The override of updateSelection() introduced in eclipse-platform#3871 left CloseUnrelatedProjectsAction enabled after the last unrelated project was closed, because the cheap enablement check no longer consulted the project graph. Restoring the previous behavior is the simplest fix while a follow-up addresses the original UI-thread cost separately. Refs eclipse-platform#2636
There was a problem hiding this comment.
Pull request overview
This PR reverts the prior change that made CloseUnrelatedProjectsAction.updateSelection() “cheap”, restoring the original (correct) enablement behavior that reflects whether any open unrelated projects actually remain to be closed.
Changes:
- Removes the
updateSelection(IStructuredSelection)override that bypassed unrelated-project computation during selection changes. - Restores enablement behavior to rely on the inherited
CloseResourceAction.updateSelection(), which consultsgetSelectedResources()(overridden here to compute unrelated projects).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Contributor
Author
|
Revert restores the old (blocking / delaying startup) behavior, merging |
Contributor
|
Has this reached simrel staging? RCPTT still fails. |
Contributor
|
The staging repository won’t change until the platform contributes M3 in two weeks. But, given M2 is complete, the platform could contribute something sooner as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR #3871 (commit 3aaea37) and the follow-up Javadoc fix in 3b23ac5.
After #3871 the cheap
updateSelection()override stopped consulting the project graph, soCloseUnrelatedProjectsActionstayed enabled after the last unrelated project was closed (also visible as an RCPTT regression on platform staging). Reverting restores the previous correct enablement; the original UI-thread cost addressed in #3871 can be tackled separately without breaking the action.Closes #3941.
Refs #2636