Give FormHeading a distinct background in the light theme#3950
Conversation
|
Just one question that just now comes to my mind: |
All I can say that Version: 2026-03 (4.39) does NOT have the gray background. Why? I don't know and don't have the interest to research that. |
Let me have a look if I can find out something... |
Test Results 858 files + 20 858 suites +20 51m 25s ⏱️ + 14m 9s For more details on these failures, see this check. Results for commit a93ab2a. ± Comparison against base commit 774c047. ♻️ This comment has been updated with latest results. |
|
@BeckerWdf any news? I think M3 closes soon, so you to decide if you want this in the next release or not, I do not have a strong opinion here. |
We did not remove the header styling by intention... |
|
So I have no objections to give the header that grey background |
|
No objection is not sufficient to merge. I also have no objections .;-) Just decide: yes / no |
|
yes |
The as-shipped light theme set both Form and FormHeading to #ffffff plus a matching text-background-color, so the form heading area was visually indistinguishable from the form body. Split the joint Form/FormHeading rule, set FormHeading and the Form's text-background-color to #eaeaea (matching the Section title bar) so the heading stands out against the white body.
vogella
force-pushed
the
light-theme-form-chrome
branch
from
be3acaf to
a93ab2a
Compare
|
Unrelated unit test error. |
2 participants
The light theme set both
FormandFormHeadingto#ffffffplus a matchingtext-background-color, so the form heading area (the bar containing the editor title and toolbar icons) was visually indistinguishable from the form body and the icons looked free-floating.Split the joint
Form, FormHeadingrule ine4-light_globalstyle.cssand giveFormHeading(and the Form'stext-background-color)#eaeaea— the same color the Section title bars already use — so the heading reads as a distinct band against the white body.