Skip to content

Drop unreachable IOException from CSSEngine String overloads #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 2 commits into from
May 7, 2026
Merged

Drop unreachable IOException from CSSEngine String overloads #3976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee3bc8f
Drop unreachable IOException from CSSEngine String overloads
vogella May 7, 2026
3b795b2
Version bump(s) for 4.40 stream
eclipse-platform-bot May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.css.core/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Bundle-SymbolicName: org.eclipse.e4.ui.css.core;singleton:=true
Bundle-Name: %pluginName
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Bundle-Version: 0.14.600.qualifier
Bundle-Version: 0.14.700.qualifier
Export-Package: org.eclipse.e4.ui.css.core;x-internal:=true,
org.eclipse.e4.ui.css.core.css2;x-friends:="org.eclipse.e4.ui.css.swt.theme,org.eclipse.e4.ui.css.swt,org.eclipse.e4.ui.css.jface",
org.eclipse.e4.ui.css.core.dom;x-friends:="org.eclipse.e4.ui.css.swt,org.eclipse.ui.views.properties.tabbed,org.eclipse.ui.forms",
Expand Down
6 changes: 3 additions & 3 deletions bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/engine/CSSEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public interface CSSEngine {
/**
* Parse style declaration from String style.
*/
CSSStyleDeclaration parseStyleDeclaration(String style) throws IOException;
CSSStyleDeclaration parseStyleDeclaration(String style);

/**
* Parse style declaration from Reader reader.
Expand All @@ -83,7 +83,7 @@ public interface CSSEngine {
/**
* Parse CSSValue from String value.
*/
CSSValue parsePropertyValue(String value) throws IOException;
CSSValue parsePropertyValue(String value);

/**
* Parse CSSValue from InputStream stream.
Expand All @@ -105,7 +105,7 @@ public interface CSSEngine {
/**
* Parse Selectors from String value.
*/
SelectorList parseSelectors(String text) throws IOException;
SelectorList parseSelectors(String text);

/**
* Parse Selectors from InputSource value.
Expand Down
27 changes: 18 additions & 9 deletions ....eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/AbstractCSSEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,12 @@ private void checkInputSource(InputSource source) throws IOException {
/*--------------- Parse style declaration -----------------*/

@Override
public CSSStyleDeclaration parseStyleDeclaration(String style) throws IOException {
Reader reader = new StringReader(style);
return parseStyleDeclaration(reader);
public CSSStyleDeclaration parseStyleDeclaration(String style) {
try {
return parseStyleDeclaration(new StringReader(style));
} catch (IOException e) {
throw new IllegalStateException("StringReader cannot throw IOException", e); //$NON-NLS-1$
}
}

@Override
Expand All @@ -307,9 +310,12 @@ public CSSStyleDeclaration parseStyleDeclaration(InputSource source) throws IOEx
/*--------------- Parse CSS Selector -----------------*/

@Override
public SelectorList parseSelectors(String selector) throws IOException {
Reader reader = new StringReader(selector);
return parseSelectors(reader);
public SelectorList parseSelectors(String selector) {
try {
return parseSelectors(new StringReader(selector));
} catch (IOException e) {
throw new IllegalStateException("StringReader cannot throw IOException", e); //$NON-NLS-1$
}
}

@Override
Expand Down Expand Up @@ -350,9 +356,12 @@ public CSSValue parsePropertyValue(InputStream stream) throws IOException {
}

@Override
public CSSValue parsePropertyValue(String value) throws IOException {
Reader reader = new StringReader(value);
return parsePropertyValue(reader);
public CSSValue parsePropertyValue(String value) {
try {
return parsePropertyValue(new StringReader(value));
} catch (IOException e) {
throw new IllegalStateException("StringReader cannot throw IOException", e); //$NON-NLS-1$
}
}

@Override
Expand Down
Loading