[performance] Avoid O(n^2) in DeadlockDetector.lockAcquired()

[jukzi]

With n conflicting rules. Has been observed as severe hotspot in workspace with n= ~1000 projects

Functionality is tested with
IJobManagerTest.testTransferToJobWaitingOnChildRule()

[laeubi]

Looks reasonable.

[laeubi]

I think I found an issue here.

[laeubi]

If we talking about performance, it might be that

//only need two passes through all the locks to pick up all conflicting rules
int NUM_PASSES = 2;

could be one pass if no new items where added to the set?

[jukzi]

@laeubi please accept the code style as is or proof that your optimizations perform faster. To me it looks like adding additional code does not help.

[laeubi]

@laeubi please accept the code style as is or proof that your optimizations perform faster. To me it looks like adding additional code does not help.

Its hard to tell as you have not given any numbers of the "severe hotspot in workspace with n= ~1000 projects" I just assumed that if you want to avoid loop over, then you want to avoid copy as well as it also requires time but it is of course just a rough idea.

[jukzi]

I only want to avoid n times ArrayList#contains for obvious performance reasons if the set becomes just large enough, especially if all of those n jobs do it.

[laeubi]

Looks good now

[github-actions]

Test Results

 1 743 files   - 12   1 743 suites   - 12   1h 36m 59s ⏱️ + 6m 3s
 4 170 tests ± 0   4 147 ✅ ± 0   23 💤 ±0  0 ❌ ±0 
13 019 runs   - 88  12 853 ✅  - 87  166 💤  - 1  0 ❌ ±0 

Results for commit 8ff13cc. ± Comparison against base commit d3dd4bf.

[jukzi]

Looks good now

@laeubi thanks for all the good findings.

[jukzi]

build #7 failed with Failed to execute goal org.apache.maven.plugins:maven-war-plugin:3.4.0:war (default-war) on project infocenter-app: Error assembling WAR: Problem creating war: Execution exception: Java heap space -> [Help 1], restarted build

[merks]

Looks good now

@laeubi thanks for all the good findings.

Good improvements, good suggestions, and good team work guys! 🏆

[jukzi]

ignoring unrelated failure in windows verification: eclipse-platform/eclipse.platform.swt#1801
(but i wonder why does platform start a UI?)