Marked long-time deprecated API in Plugin for removal#1864
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Test Results 1 764 files ±0 1 764 suites ±0 1h 28m 13s ⏱️ - 17m 44s For more details on these failures, see this check. Results for commit 4fbedd6. ± Comparison against base commit 2e1acee. ♻️ This comment has been updated with latest results. |
|
the preference API is still used by Ant.... So this should be updated to not mark this API for deletion as I assume no one plans to work on updating Ant to the non-deprecated preferences. |
0b38748 to
04e40c6
Compare
HannesWell
left a comment
There was a problem hiding this comment.
the preference API is still used by Ant.... So this should be updated to not mark this API for deletion as I assume no one plans to work on updating Ant to the non-deprecated preferences.
Would it be difficult to migrate away from the old API in Eclipse-ANT?
I don't know, never looked into this. In my more active time Ant was heavily "guarded" by others so it never felt like worth trying to invest into this code. |
Plugin contains methods which are marked since a long time as deprecated. Marking these for removal to give us the flexibility to remove these after API freeze period if needed. Triggered by an investigation of ILegacyPreferences from Equinox which calls some of these methods in PreferenceServiceRegistryHelper during startup. savePluginPreferences and getPluginPreferences are not yet marked for deletion as they are still used by the Ant tooling. d
04e40c6 to
4fbedd6
Compare
|
The test failure 1 out of 3 runs failed: testBug546710_ConsoleCreationRaceCondition (org.eclipse.debug.tests.console.ProcessConsoleManagerTests in Windows seems unrelated. |
It's really quite widely used beyond just Ant, including by other methods that return a deprecated Preferences instance. |

Plugin contains methods which are marked since a long time as deprecated. Marking these for removal to give us the flexibility to remove these after API freeze period if needed.
Triggered by an investigation of ILegacyPreferences from Equinox which calls some of these methods in PreferenceServiceRegistryHelper during startup.