Skip to content

Marked long-time deprecated API in Plugin for removal#1864

Merged
vogella merged 2 commits into
eclipse-platform:masterfrom
vogella:marked-for-removal-deprecate-plugin-api
May 16, 2025
Merged

Marked long-time deprecated API in Plugin for removal#1864
vogella merged 2 commits into
eclipse-platform:masterfrom
vogella:marked-for-removal-deprecate-plugin-api

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented May 9, 2025

Plugin contains methods which are marked since a long time as deprecated. Marking these for removal to give us the flexibility to remove these after API freeze period if needed.

Triggered by an investigation of ILegacyPreferences from Equinox which calls some of these methods in PreferenceServiceRegistryHelper during startup.

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 79f240ae2a905c490e20723551b593e4386d39e1 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 9 May 2025 10:15:58 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index d7ec81e54a..ed76b75691 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.33.0.qualifier
+Bundle-Version: 3.33.100.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2025

Test Results

 1 764 files  ±0   1 764 suites  ±0   1h 28m 13s ⏱️ - 17m 44s
 4 381 tests ±0   4 356 ✅ ±0   24 💤 ±0  1 ❌ ±0 
13 143 runs  ±0  12 975 ✅ ±0  167 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4fbedd6. ± Comparison against base commit 2e1acee.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented May 9, 2025

the preference API is still used by Ant.... So this should be updated to not mark this API for deletion as I assume no one plans to work on updating Ant to the non-deprecated preferences.

@vogella vogella force-pushed the marked-for-removal-deprecate-plugin-api branch 3 times, most recently from 0b38748 to 04e40c6 Compare May 13, 2025 12:36
Copy link
Copy Markdown
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the preference API is still used by Ant.... So this should be updated to not mark this API for deletion as I assume no one plans to work on updating Ant to the non-deprecated preferences.

Would it be difficult to migrate away from the old API in Eclipse-ANT?

Comment thread runtime/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/Plugin.java Outdated
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented May 16, 2025

the preference API is still used by Ant.... So this should be updated to not mark this API for deletion as I assume no one plans to work on updating Ant to the non-deprecated preferences.

Would it be difficult to migrate away from the old API in Eclipse-ANT?

I don't know, never looked into this. In my more active time Ant was heavily "guarded" by others so it never felt like worth trying to invest into this code.

vogella and others added 2 commits May 16, 2025 08:36
Plugin contains methods which are marked since a long time as
deprecated. Marking these for removal to give us the flexibility to
remove these after API freeze period if needed.

Triggered by an investigation of ILegacyPreferences from Equinox which
calls some of these methods in PreferenceServiceRegistryHelper during
startup.

savePluginPreferences and getPluginPreferences are not yet marked for
deletion as they are still used by the Ant tooling.
d
@vogella vogella force-pushed the marked-for-removal-deprecate-plugin-api branch from 04e40c6 to 4fbedd6 Compare May 16, 2025 06:37
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented May 16, 2025

The test failure 1 out of 3 runs failed: testBug546710_ConsoleCreationRaceCondition (org.eclipse.debug.tests.console.ProcessConsoleManagerTests in Windows seems unrelated.

@vogella vogella merged commit 127d70a into eclipse-platform:master May 16, 2025
16 of 18 checks passed
@vogella vogella deleted the marked-for-removal-deprecate-plugin-api branch May 16, 2025 09:31
@merks
Copy link
Copy Markdown
Contributor

merks commented May 18, 2025

the preference API is still used by Ant.... So this should be updated to not mark this API for deletion as I assume no one plans to work on updating Ant to the non-deprecated preferences.

It's really quite widely used beyond just Ant, including by other methods that return a deprecated Preferences instance.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants