Skip to content

Mark for removal i platform configuration factory#1867

Merged
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:mark-for-removal-_IPlatformConfiguration_Factory
May 12, 2025
Merged

Mark for removal i platform configuration factory#1867
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:mark-for-removal-_IPlatformConfiguration_Factory

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented May 9, 2025

No description provided.

@vogella vogella force-pushed the mark-for-removal-_IPlatformConfiguration_Factory branch 2 times, most recently from 91b0715 to c6085b4 Compare May 9, 2025 10:45
@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

eclipse-platform-bot commented May 9, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

update/org.eclipse.update.configurator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 8bf9b9d8e2962a20cf8d24e310e1457f96ba402f Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 9 May 2025 12:50:40 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
index 5f045c7318..f1a5deb034 100644
--- a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
+++ b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.update.configurator; singleton:=true
-Bundle-Version: 3.5.600.qualifier
+Bundle-Version: 3.5.700.qualifier
 Bundle-Activator: org.eclipse.update.internal.configurator.ConfigurationActivator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2025

Test Results

 1 764 files  ±0   1 764 suites  ±0   1h 27m 45s ⏱️ -53s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit a39ce19. ± Comparison against base commit d651768.

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the mark-for-removal-_IPlatformConfiguration_Factory branch 3 times, most recently from 8e419d8 to 037e2db Compare May 9, 2025 15:02
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented May 9, 2025

Does anyone know what to do to solve the Javadoc warnings?

[Check warning on line 21 in 15:06:26.594 [WARNING] /home/jenkins/agent/workspace/eclipse.platform_PR-1867/update/org.eclipse.update.configurator/src/org/eclipse/update/internal/configurator/BundleGroupComponent.java](https://github.com/eclipse-platform/eclipse.platform/pull/1867/files#annotation_34551717561) 

@jenkins-eclipse-platform
jenkins-eclipse-platform
/ JavaDoc
-

NORMAL:
[removal] IPlatformConfiguration in org.eclipse.update.configurator has been deprecated and marked for removal

This points to an import statement and I see no warning in my IDE.

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented May 10, 2025

@fedejeanne do you know how I can remove the Javadoc errors? This is similar to what you might have seen in eclipse-platform/eclipse.platform.ui#2966

@fedejeanne fedejeanne force-pushed the mark-for-removal-_IPlatformConfiguration_Factory branch from 037e2db to b07a32f Compare May 10, 2025 12:13
@fedejeanne
Copy link
Copy Markdown
Member

@fedejeanne do you know how I can remove the Javadoc errors? This is similar to what you might have seen in eclipse-platform/eclipse.platform.ui#2966

I don't I had warnings in the imports, I only had warnings in the usage of the methods (they were not imported statically so it was a different scenario).

I also don't see a warning in my IDE and can't find any configuration to activate such warning. The only way I know to get rid of such warnings is to not have the imports i.e. use fully qualified names. I took the liberty of do that for BundleGroupComponent in b07a32f, I hope that's OK. If that works and you like the final state of the class, you could try the same in the other classes. Otherwise just revert to your last version, no harm no foul :-)

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented May 10, 2025

Thanks @fedejeanne the removal of the import is a great idea.

@vogella vogella force-pushed the mark-for-removal-_IPlatformConfiguration_Factory branch from b07a32f to b50693e Compare May 10, 2025 14:55
These interfaces are currently only used by ConfiguratorUtils that is
already marked for removal on 2024-03
@vogella vogella force-pushed the mark-for-removal-_IPlatformConfiguration_Factory branch from b50693e to a39ce19 Compare May 11, 2025 09:56
@vogella vogella merged commit babaec5 into eclipse-platform:master May 12, 2025
18 checks passed
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented May 12, 2025

Thanks @fedejeanne for the help

@vogella vogella deleted the mark-for-removal-_IPlatformConfiguration_Factory branch May 12, 2025 06:45
@fedejeanne
Copy link
Copy Markdown
Member

My pleasure :-)

Sorry for the late response, I finally managed to stay offline for the rest of the weekend after my last comment (it took some convincing though 😅 )

Have a nice day!

akurtakov added a commit to akurtakov/chemclipse that referenced this pull request Nov 25, 2025
* Dropins
(https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fp2_dropins_format.html
) are by design unsafe as if any conflict or missing dependency arise
they will not be installed. It is strongly recommended to use p2
operation to install directly thus no need to manually start the dropins
bundle.
* Update configurator (org.eclipse.update.configurator) is pre p2 thing
that is simply not needed nowadays and even marked fro removal in
2025-06 (eclipse-platform/eclipse.platform#1867
)

This should have some (probably minimal) effect on startup time but
what's more important is:
* reduces the unexpected installation possibilities of someone using
dropins
* prepares for the actual removal of update.configurator
Mailaender pushed a commit to eclipse-chemclipse/chemclipse that referenced this pull request Nov 25, 2025
* Dropins
(https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fp2_dropins_format.html
) are by design unsafe as if any conflict or missing dependency arise
they will not be installed. It is strongly recommended to use p2
operation to install directly thus no need to manually start the dropins
bundle.
* Update configurator (org.eclipse.update.configurator) is pre p2 thing
that is simply not needed nowadays and even marked fro removal in
2025-06 (eclipse-platform/eclipse.platform#1867
)

This should have some (probably minimal) effect on startup time but
what's more important is:
* reduces the unexpected installation possibilities of someone using
dropins
* prepares for the actual removal of update.configurator
akurtakov added a commit to akurtakov/openchrom that referenced this pull request Nov 25, 2025
* Dropins
(https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fp2_dropins_format.html
) are by design unsafe as if any conflict or missing dependency arise
they will not be installed. It is strongly recommended to use p2
operation to install directly thus no need to manually start the dropins
bundle.
    * Update configurator (org.eclipse.update.configurator) is pre p2
thing that is simply not needed nowadays and even marked fro removal in
2025-06 (eclipse-platform/eclipse.platform#1867
)

This should have some (probably minimal) effect on startup time but
what's more important is:
* reduces the unexpected installation possibilities of someone using
dropins
* prepares for the actual removal of update.configurator

Continuation of
eclipse-chemclipse/chemclipse#2574
Mailaender pushed a commit to OpenChrom/openchrom that referenced this pull request Nov 25, 2025
* Dropins
(https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fmisc%2Fp2_dropins_format.html
) are by design unsafe as if any conflict or missing dependency arise
they will not be installed. It is strongly recommended to use p2
operation to install directly thus no need to manually start the dropins
bundle.
    * Update configurator (org.eclipse.update.configurator) is pre p2
thing that is simply not needed nowadays and even marked fro removal in
2025-06 (eclipse-platform/eclipse.platform#1867
)

This should have some (probably minimal) effect on startup time but
what's more important is:
* reduces the unexpected installation possibilities of someone using
dropins
* prepares for the actual removal of update.configurator

Continuation of
eclipse-chemclipse/chemclipse#2574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants