Replace manual image instantiation of Image in AsynchronousViewer and TreeModelLabelProvider with createImage() for better scaling of icons

[arunjose696]

Replaced direct image creation using new Image(..., descriptor.getImageData()) with descriptor.createImage() in both AsynchronousViewer and TreeModelLabelProvider. This change ensures that icons now render sharply even at higher zoom levels (e.g., 225%).

Screenshots at 225% (I have circled in red in the first image for the icon that is being affected with the change)

Current Behavior

After This Change

Steps to Reproduce
To observe the change in AsynchronousViewer, run the Memory View in Eclipse CDT. The icons are shown during debugging when a C++ application is monitored with memory watches, and the variable’s memory address changes.

While it requires some effort to set up, the change itself is minimal and self-explanatory.

Contributes to: vi-eclipse/Eclipse-Platform#199

[arunjose696]

The change in TreeModelLabelProvider can be seen in more places, eg in icons of the breakpoints. Below are images in 225% zoom

Current Behavior

After This Change

[github-actions]

Test Results

 1 893 files  ±0   1 893 suites  ±0   1h 27m 44s ⏱️ - 3m 5s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 65cf0a9. ± Comparison against base commit 4ed0923.

♻️ This comment has been updated with latest results.

[HeikoKlare]

Good catch, thank you! The change looks good.

@arunjose696 can you please remove the reference to the "external" vi-eclipse GitHub organization from the commit message?

[arunjose696]

Good catch, thank you! The change looks good.

@arunjose696 can you please remove the reference to the "external" vi-eclipse GitHub organization from the commit message?

done.

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 662132da1b71f18a371cbe21f0b705f62cfa8545 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 5 Jun 2025 14:03:25 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
index 9474268cec..82916aa04e 100644
--- a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.ui; singleton:=true
-Bundle-Version: 3.18.800.qualifier
+Bundle-Version: 3.18.900.qualifier
 Bundle-Activator: org.eclipse.debug.internal.ui.DebugUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.