Clean Code for ant/org.eclipse.ant.launching

[eclipse-platform-bot]

The following cleanups where applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Convert control statement bodies to block
• Make inner classes static where possible
• Remove trailing white spaces on all lines
• Remove unnecessary array creation for varargs
• Remove unnecessary suppress warning tokens
• Remove unused imports
• Replace deprecated calls with inlined content where possible
• Use pattern matching for instanceof

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ant/org.eclipse.ant.launching/META-INF/MANIFEST.MF
runtime/features/org.eclipse.core.runtime.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From f257e6dc1b829ee958fd35af57999c3af08b9e5d Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 6 Jun 2025 04:33:21 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/ant/org.eclipse.ant.launching/META-INF/MANIFEST.MF b/ant/org.eclipse.ant.launching/META-INF/MANIFEST.MF
index 701a5b50f8..9c9a10f1a4 100644
--- a/ant/org.eclipse.ant.launching/META-INF/MANIFEST.MF
+++ b/ant/org.eclipse.ant.launching/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Localization: plugin
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ant.launching;singleton:=true
-Bundle-Version: 1.4.700.qualifier
+Bundle-Version: 1.4.800.qualifier
 Bundle-Activator: org.eclipse.ant.internal.launching.AntLaunching
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.debug.core;bundle-version="[3.12.0,4.0.0)",
diff --git a/runtime/features/org.eclipse.core.runtime.feature/feature.xml b/runtime/features/org.eclipse.core.runtime.feature/feature.xml
index be6874fea0..5e0968005c 100644
--- a/runtime/features/org.eclipse.core.runtime.feature/feature.xml
+++ b/runtime/features/org.eclipse.core.runtime.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.core.runtime.feature"
       label="%featureName"
-      version="1.4.800.qualifier"
+      version="1.4.900.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

 1 764 files  ±0   1 764 suites  ±0   1h 31m 41s ⏱️ + 6m 4s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 2ebc9f7. ± Comparison against base commit 917ba29.

[iloveeclipse]

@akurtakov : this causes multiple compilation errors in the workspace

Description	Resource	Path	Location	Type
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InputHandlerSetter.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 38	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InputHandlerSetter.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 42	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InternalAntRunner.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 195	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InternalAntRunner.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 435	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InternalAntRunner.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 582	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InternalAntRunner.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 587	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InternalAntRunner.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 687	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InternalAntRunner.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 898	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InternalAntRunner.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 1014	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InternalAntRunner.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 1040	Java Problem
Non-externalized string literal; it should be followed by //$NON-NLS-<n>$	InternalAntRunner.java	/org.eclipse.ant.launching/remote/org/eclipse/ant/internal/launching/remote	line 1290	Java Problem

[akurtakov]

The real question is why are they missing in the verifications. @laeubi do you have any idea? #1905 fixes the problems

[laeubi]

I have no idea, maybe ant disables some of the warnings?

[merks]

I'm fixing that:

#1905

I think there was a random unrelated test failure so am build that again.